Unless I'm mistaken, the string filter operator 'Is not empty (NULL)' should read 'Is not empty (NOT NULL)'...

Made a patch if that is indeed the case.

CommentFileSizeAuthor
#5 views-422434-5.patch2.34 KBAnonymous (not verified)
#2 views_422434_2.patch734 bytesAnonymous (not verified)
views_handler_filter_string.inc_.patch475 bytesAnonymous (not verified)

Comments

dawehner’s picture

dawehner
Primary language German
commented

i think the NULL is the description for empty and not for not empty,
but i'm not native

Anonymous’s picture

Anonymous (not verified) commented
Category: bug » task
Status: Active » Needs review
StatusFileSize
new views_422434_2.patch734 bytes

In that case, maybe it should be 'Is not empty/NULL'... Patch attached.

dawehner’s picture

dawehner
Primary language German
commented

As I said above NULL is just a description for EMPTY.

with / some people may see a difference in their php brain.

empty(0) <=> TRUE
0 === NULL <=> FALSE

But this is not php its sql :)

merlinofchaos’s picture

merlinofchaos commented

I like (NOT NULL) but I just noticed that there are at least 4 occurances of the string that all need to be caught:

handlers/views_handler_filter_in_operator.inc:          'title' => t('Is not empty (NULL)'),
handlers/views_handler_filter_string.inc:          'title' => t('Is not empty (NULL)'),
handlers/views_handler_filter_many_to_one.inc:          'title' => t('Is not empty (NULL)'),
handlers/views_handler_filter_numeric.inc:          'title' => t('Is not empty (NULL)'),
Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new views-422434-5.patch2.34 KB

Here's an updated patch for the latest 2.x-dev:

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

I'm now convinced. This string makes more sense.

merlinofchaos’s picture

merlinofchaos commented
Status: Reviewed & tested by the community » Fixed

Committed to all 3 branches. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.