Date fields terminate CSV export on some versions of PHP

Well, I generally follow the Drupal policy of not supporting fixed php bugs so I'm not looking to commit this right now.

However, just from a once over and observation by merlinofchaos, wouldn't the patch be better as simply:

    foreach (array_keys($fields) as $key) {
      if (empty($fields[$key]->options['exclude'])) {
        $items[$key] = $fields[$key]->theme($row);
      }
    }

Hi !
I tried this patch 'cause I had the problem you mentioned.
It worked!! ...now I can export all fields of the colomuns.
However it exports only the last row..

Works with "views_bonus_export.module.patch" under PHP 5.2.0-8 (Debian etch)
Thanks!

here is patched beta2 version
remove .txt

It works for me!!!
great!
thank you! :-)

@drupalok Please don't upload entire modules. If you are going to patch something provide the patch only.

Marking this as won't fix for now.

@neclimdul

I don't agree.

there are many people out there who are not into patching stuff at all. (actually i am more or less one of them). they are happy to get a patched module, cause it safes them a lot of time and they dont have to understand command line stuff. sure they have to check wheater it works for them...

for clearance: it was not me who provided the patch. i just applied it to the beta version, so people can use it.

No, this has nothing to do with convenience but is a matter of courtesy. A patch is much smaller and accurately displays the changes being made. A module wastes space on the drupal infrastructure and does not impart the changes made to the module.

The format we use for patches is not that hard that and those not familiar or comfortable with command line tools can generally read it and figure out what was changed especially with one as small as this.

This is also the standard for the drupal issue queue largely for the reasons I've listed here and some others and that should be enough.

comment #1 worked for me thanks.

Still can't get this working with D6 - php 5.1 ...could anyone help me??

megh, committed something that probably fixes this.