Detailed question should be under question title
andypost - April 3, 2009 - 14:01
| Project: | Frequently Asked Questions |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Description
Current state looks like
Q: [question]
A:
[detailed question]
[answer]
This all because detailed question attaches to node->body at hook_view
Patch changes this to faq_view_question
| Attachment | Size |
|---|---|
| faq-detail.patch | 1.26 KB |
#1
This patch makes
Q: [question]
[detailed question]
A:
[answer]
#2
Patch against current DRUPAL-6--1
#3
Committed, though I had to fix it for the 'Clicking on question opens/hides the answer" layout as really the long question shouldn't appear until the short question was clicked.
#4
You right, but now there's no ability to view a full node!!! All other 3 options hides long question forgiving about settings 'Question length' so long question is visible only on /faq page
I think that long question should depend only on "Question length" setting for /faq page and node-page
#5
Ok you're going to have to explain that better, because I'm not following your description.
#6
As descriptions said for the "question details" - it should be displayed at all layouts with answer and could replace short question on /faq page
Description of "Question length" radios is "The length of question text to display on the FAQ page. The short question will always be displayed in the FAQ blocks."
This setting for /faq page, I suppose...
Description of "Question details (optional)" field is "Longer question text. This will be displayed in all layouts where the answer appears, in addition to the shorter question text."
This tells that answer should be prefixed with this field, is not it?
Find another bug - "Question details" is displayed at top of node form (weight -1 against weight 0 for node-title)
#7
I spend some time with debugger and check all values, it looks like something changed at theme layer so here patch:
1) Update a weight of node->title to show it before detailed question
2) Show detailed question before answer every-time when answer displayed
#8
This happens only in INLINE mode, so going to dig deeper
#9
Now it works as described above
#10
I've committed the node field weight change.
However I haven't committed the other change, as I said above, for the 'Clicking on question opens/hides the answer" layout, and when displaying both long and short questions, the long question shouldn't appear until the short question is clicked. Maybe the help text needs to be changed if that isn't clear.
#11
Released in faq 6.x-1.9.