If there are no items matching the taxonomy tcker filter the code produces an empty AND clause - namely - '()'.

By first checking if the taxonomy id array is empty we can fix the SQL statement.

Also by checking if any nodes were we can show the block if one or more nodes exist.

Paddy.

CommentFileSizeAuthor
taxonomy_ticker.module.patch1.74 KBpaddy_deburca

Comments

mathieu’s picture

Assigned: paddy_deburca » mathieu
Status: Active » Fixed

Patch applied, thanks!

chaos21in’s picture

Title: Fix ticker ticker when there are no terms defined, and don't display and empty block. » Fatal error: Call to undefined function: theme_add_style() in ticker.module on line 68
Version: 4.6.x-1.x-dev » master
Priority: Normal » Critical
Status: Fixed » Active

i am using drupal 4.6.5 and i am getting this problem today...i tried taxonomy_ticker.module for both drupal 4.6.5 version and the most recent from cvs..

Fatal error: Call to undefined function: theme_add_style() in ***/drupal/modules/taxonomy_ticker/taxonomy_ticker.module on line 68

chaos21in’s picture

Status: Active » Closed (fixed)

Ok maybe this is because i used taxonomy.module v1.219 2005/08/25 and not v1.249 2005/12/31 ...now when i upgraded it..it is solved..

chaos21in’s picture

Version: master » 4.6.x-1.x-dev
Status: Closed (fixed) » Active

sorry ...it is not solved as i mentioned above...After upgradation other problem started...so i used all taxonomy modules which is only meant for drupal 4.6.5 version...when i activated them from admin settings..and log out, i started getting the above fatal error.....when i removed taxonomy_ticker module i got error in taxonomy_assoc module...after removing this one also....i logged in and saw the logs...The error messages there were:

page not found Jan 6 2006 - 11:48 modules/taxonomy_ticker/taxonomy_ticker.css not found.
page not found Jan 6 2006 - 11:48 modules/taxonomy_ticker/taxonomy_ticker.js not found.
access denied Jan 6 2006 - 12:02 admin/settings/taxonomy_browser denied access.
page not found Jan 6 2006 - 12:01 modules/taxonomy_assoc/taxonomy_assoc.css not found.

These are when i logged out....so one access deny message is understandable..but why these page not found error,,eventhough these css and js files are there i those folders..

mathieu’s picture

Title: Fatal error: Call to undefined function: theme_add_style() in ticker.module on line 68 » Fix ticker when there are no terms defined, and don't display an empty block.
Status: Active » Closed (fixed)

It would have been *much* better to open a new issue instead of renaming this one (which has nothing to do with this new bug).

I'll try to reproduce this bug, but the "file not found" errors are very mysterious to me, especially since you are telling us that the files are there. If you modified your .htaccess, maybe there is a permission error in it... (I've seen that before)

The theme_add_style function is in themes.inc and I can't see why it would cause any trouble. This makes me think your install could be "slightly" messed up.

I'm re-closing and renaming this bug, please open a new one if this is a new issue.