I co-maintain the Node Gallery Module and used some of your imagecache code as inspiration to improve our presets. I noticed a bug that existed in your module: if you enable the module, disable (then uninstall it) and reenable it again, it will duplicate the imagecache presets that are installed by default. This is probably a fringe issue but the fix is easy!

I fixed it by merely pulling an array of all the imagecache preset names and made sure the name I was trying to install didn't already exist. This is probably a good practice for your module as your names are pretty generic and it is likely you might step on the toes of an already-existing preset!

See our CVS log to see how I fixed it.

Comments

kmonty’s picture

kmonty
He/Him
Location Berlin, DE + SF, CA
commented

I made some adjustments to install script, check in out in the cvs repository.

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented
Status: Active » Needs work

Hi, I know this was ages ago, but any chance of a patch? Please patch against current Drupal CVS (there'll be a new dev snapshot in about 6 hours time with the latest .install file incorporated).

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented
Status: Needs work » Needs review

I'm sorry, I totally misunderstood what you were saying. Read too quickly. Please ignore, I'm reviewing now, and thanks for sharing! =)

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented
Status: Needs review » Fixed

Ok, fixed and committed to CVS. Thanks again! =)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.