I have just installed uc_upsell into my Drupal 6 Ubercart based site. I have configured the module (Global Settings, Cart Pane) via admin/store/settings/upsell and have added a block to the product pages. In a nutshell - the block URLs for the related products are all formed correctly, as are the thumbnails, prices and the title however the related products in the Cart Pane (the images/thunbnails) all have the same URL (http://***My site***/Node). This, of course does not resolve to the product represented by the thumbnails. The price information is also incorrect (it reads 0.00) and there is no title. The image alt tag is present.

I suspect this may be an installation issue as I could not get the module to install until I added a 'uc_upsell_install' function as follows:

function uc_upsell_install() {
drupal_install_schema('uc_upsell');
}

As far as my DB schema is concerned, I have one table - uc_upsell_products.

I am going to review the installation files for Drupal version 5 to see if I can get some clues as to whether my DB schema is complete or not but if anyone can spot an issue with my installation from what I have written above, please shout.

Thanks.

CommentFileSizeAuthor
#9 uc_upsell.module.cartlinks.patch11.85 KBtorgospizza
#3 uc_upsell_cartpane-423232.module.patch1.9 KBtorgospizza

Comments

torgospizza’s picture

torgospizza
he/him
Primary language English
Location Portland, OR
commented

Interesting, as I haven't come across this issue yet - although I have only installed the previous 6.x version and not 1.11. I will give this a shot, but it sounds to me like you may have found part of the problem (the missing function).

If you do find something conclusive before I do, feel free to post it here.

kash99’s picture

kash99 commented

I'm having the same problems with it:

The Image links don't point to the products. They only point to .../node
Also, Buy Now shows $0 in price.

torgospizza’s picture

torgospizza
he/him
Primary language English
Location Portland, OR
commented
StatusFileSize
new uc_upsell_cartpane-423232.module.patch1.9 KB

I believe I fixed this issue regarding the cart pane links. Please test out this patch and let me know if it works for you.

torgospizza’s picture

torgospizza
he/him
Primary language English
Location Portland, OR
commented
Status: Active » Needs review
anea02’s picture

anea02 commented
Status: Needs review » Needs work

torgosPizza

Wow, that was fast! Thanks. Sorry for the delay, I had to download Cygwin (for my sins, base platform is Windows Server 2003). Patch fixed issue of pane cart related product URLs, including showing correct prices. Thumbnails resolved to the product page, both from the block and the cart pane. Unfortunately this has lead me to take testing ever so slightly further and uncover another small issue. The 'add to cart' URL does not work. URL reads '/cart/add/i6Checkout-p6_q1?destination=cart' which leads to the cart but does not add the product to the cart.

I will dig a little deeper but I wanted to reply as soon as I could.

Regards and thanks

anea02’s picture

anea02 commented

Quick update - the '6' in 'p6' is the correct node ID (fyi)

anea02’s picture

anea02 commented

Read through cart links documentation. Think I fixed it but am just checking:

Lines 776 in uc_upsell.module, changed to

$output .= l(t('Add to Cart ') . uc_currency_format($node->sell_price), "cart/add/p{$node->nid}_q1-i{$node->nid}Checkout", array('attributes' => array('class' => 'buy-related-item-buynow'), 'query' => 'destination=cart'));

Re-ordered URL so that the cart link ID comes after the node and quantity parameters. Page URL now reads:

'/cart/add/p6_q1-i6Checkout?destination=cart'

BLOCK link then worked for me.

Line 1019 changed to

$output .= l(t('Buy now ') . uc_currency_format($related->sell_price), "cart/add/p{$related->nid}_q1-i{$related->nid}Checkout", array('attributes' => array('class' => 'buy-related-item-buynow'), 'query' => 'destination=cart'));

The cart pane link then started to work. There was a typo in this line - $related was written as $relatedt at line 25, char 125 of patch file

Regards and thanks again. Great module!

torgospizza’s picture

torgospizza
he/him
Primary language English
Location Portland, OR
commented

D'oh! Can't believe I missed that typo.. and it looks like the Cart Links system must have changed ever so slightly in D6.

I'll update the patch and re-commit to CVS. Thanks for the help!

torgospizza’s picture

torgospizza
he/him
Primary language English
Location Portland, OR
commented
Status: Needs work » Needs review
StatusFileSize
new uc_upsell.module.cartlinks.patch11.85 KB

Here's a new patch against 6.x-1.11. It includes the patch from http://drupal.org/node/411644 however, so make sure you are installing against that stable release.

I've also committed these changes to CVS, so that should get picked up the next time the Dev packaging script gets run.

kash99’s picture

kash99 commented

Installed the patch on the latest stable release. It makes the cart pane disappear.

torgospizza’s picture

torgospizza
he/him
Primary language English
Location Portland, OR
commented

Just the pane containing upsell items? I think I ran into this issue before... I did make changes to how the block is rendered, but it shouldn't have broken anything, I will apply the patch on a new install of the D6 module and see if I can reproduce.

torgospizza’s picture

torgospizza
he/him
Primary language English
Location Portland, OR
commented
Status: Needs review » Fixed

Going to close this issue so we can focus on the new one.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.