Drop automatic view creation

I see what you're saying. I once proposed replacing these with a single view that accepts arguments.

I'd rather make the generation of default Views a configurable option since it saves casual users a lot of time. I'd be happy to review a patch that makes this a simple checkbox under the main nodequeue settings.

Also, I'm not sure what you mean by :
"I cannot use it directly, because the name is nodequeue_X, and if I try to export that view to code in my own module with that name then Views breaks."

How and why does it break?

Thanks!

Probably because having multiple views with the same name in exports is bad. But at that point you should be cloning the view. =)

I think the automatic view generation is necessary to have available, but I have no issue with turning it off.

what about a variable called
'nodequeue_automatic_views_generation' and this is placed in hook_views_default_views.

this should be all, so the developer can disable if needed

Hello everybody.

For everyone trying to store his overridden default views in code while avoiding the clone-disable trick above, there is a views hook that can help.
It's hook_views_default_views_alter(&$views) and although undocumented it's use is similar to this hook_views_default_views().

An implementation could go like this

<?php
/**
 * Implementation of hook_views_default_views_alter().
 */
function xxx_views_default_views_alter(&$views){
	include_once('export_tab_dump.php');
  return $views;
}
?>

Where
xxx is your views code holding module and
export_tab_dump.php is the output for the views export tab for a view.

I have tested it with nodequeue as well as with other default views and works nicely.

Actually, that code isn't quite correct (although it probably works). hook_views_default_views_alter works by altering the views array that it receives as an argument. It therefore doesn't need a return value.

Personally, I like to keep each view in a separate file in a subdirectory, rather than exporting a whole bunch of them into a single big file. I also like to keep views that I've created via the web interface in a separate subdirectory from other modules' default views that I'm overriding. I therefore create two separate subdirectories in my views code holding module, named "includes" and "alter_includes" respectively. I pull them into my site using the following implementations of hook_views_default_views() and hook_views_default_views(&$views), respectively:

<?php
/**
 *  Implements hook_views_default_views().
 */

function mymodule_views_default_views() {
  $views = array();
  $path = drupal_get_path('module', 'mymodule') . '/includes';
  $files = drupal_system_listing('.inc$', $path, 'name', 0);
  foreach($files as $file) {
    include_once $file->filename;
  }
  return $views;
}

/**
* Implementation of hook_views_default_views_alter().
*/
function mymodule_views_default_views_alter(&$views){
  $path = drupal_get_path('module', 'mymodule') . '/alter_includes';
  $files = drupal_system_listing('.inc$', $path, 'name', 0);
  foreach($files as $file) {
    include_once $file->filename;
  }
}
?>

Here is a initial patch

The proposed patch gave a fatal error: Can't use function return value in write context, but I committed a slightly different version. Just set nodequeue_automatic_views_generation to '' and you're good to go! When this variable isn't defined, the views are created. If end users want a UI for this setting, we can always provide one later.

Please don't use an undocumented variable for this. If you'r going to add the feature, at least add a checkbox for it in the settings page.

There should also be a way to delete views that are created?

Ok, this is now a configurable option. To remove old views you can clear your Views cache if you haven't overridden the default views, or, feel free to submit an issue for any new features related to this change.

So, if this has been dropped, how do you get a view of your nodequeue to display. I don't see it as a configurable option anywhere.

I would like to use this, if possible, esp. the views part of it.

Follow-up: #743280: View not generated upon creating a Nodequeue

Any chance of a release with this in it? A fix isn't really much good until it's actually released.