Closed (fixed)
Project:
Date
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
4 Apr 2009 at 15:46 UTC
Updated:
3 Jan 2014 at 00:07 UTC
Jump to comment: Most recent
Comments
Comment #1
mgiffordI couldn't find any sub-directories within contributions/modules/date/theme/
So had trouble tracking down Attic/theme.inc
I did think that the main diff block could be shortened though:
Wouldn't that do the trick?
Mike
Comment #2
thepanz commentedI created a patch using TortoiseCVS, I don't know what is that "Attic" inside the module direcotry.. I hope that KarenS could help us!
The need for a more detailed t() without the %granularity placeholder is for non-English languages where (maybe) the sentence construction isn't so easy and linear..
What do you think?
Comment #3
mgiffordYes, I was thinking about that a bit. Tomorrow, next week, next year all could be done quite differently in different languages (unfortunately).
So this would accommodate that:
Not 100% certain that's the best way to do it for i18n, but...
Mike
Comment #4
thepanz commentedString concats in t() is a wrong way to go: auto POT extraction can't guess the right string to provide as a translation template!
Are you using latest -dev release?
Comment #5
karens commentedI agree with thePanz that the original patch will work best for translations. I also fixed a spelling error 'navigate' and added the full text for previous instead of prev. Since these are titles they don't take up any room on the page so there is plenty of space to spell things out.
So, committed. Thanks!
Comment #6
thepanz commentedThank you KarenS! :)