I added this, thought would make general table more pleasing. Otherwise just a gray table with no padding :-(

/****** Table styling */
thead th, th {
  background: #f7f7f7;
  border-bottom: 1px solid #ccc;
  color: #333;
  padding: 7px;
}

th a img {
  margin: 0;
    padding: 7px;
}

tr.even td {
  background: #F1F5FA;
    padding: 7px;
}

tr.odd td {
  background: #fff;
    padding: 7px;
}

there's already something like below.. but for something else?

body.admin tr.even, body.admin tr.odd { border: solid #ccc; border-width: 1px 0; }
body.admin tr.odd, body.admin tr.info { background-color: #eee; }
body.admin tr.even { background-color: #f5f5f5; }
body.admin tr.drag { background-color: #fffff0; }

Comments

ludo1960’s picture

ludo1960 commented

Hi,
Took your advice an the tables sure look better, I have one question though, in the forum area the table looks not too good. Using firebug I see that the CSS comes from reset.css and not the theme style.css. If I add a table width in the style.css, will that do the trick or will I break something else? Any advice?

najibx’s picture

najibx commented

not so sure ..I would simle just try.
also not sure .... reset.css is meant for what ?

ludo1960’s picture

ludo1960 commented

Thanx najibx, I was just checking befiore I started changing stuff in the style.css. A simple table:
{
width: 100%;
}

Did the trick! As for the reset.css I have no idea what it is for, but it is there in the theme so it must do something.

andregriffin’s picture

andregriffin commented
Assigned: Unassigned » andregriffin

I'll spend a bit more time on this for the next release. I've also been a little annoyed with that reset.css is doing to tables in the sites I'm building with Framework. However, the benefits of the reset far outweigh this, It's just that the elements that have been stripped down by the reset for consistency must be then re-styled, which I initially intended for the user to do, I think some basic styling will be necessary.

peterjmag’s picture

peterjmag commented

Thanks for the CSS! I did notice, however, that your row background colors override any colors for the error, ok, drag, and drag-previous classes. For example, the Available Updates page (admin/reports/updates) no longer displays green backgrounds for ok modules or red for modules that need updating. Also, any table with draggable rows (like the one on Blocks admin) no longer highlights the row being dragged.

Here's my updated CSS to fix this:

thead th, th {
  background: #f7f7f7;
  border-bottom: 1px solid #ccc;
  color: #333;
  padding: 7px;
}

th a img {
  margin: 0;
  padding: 3px 7px;
}

tr td {
  padding: 7px; /* Added from tr.even and tr.odd to apply to all cells */
}

tr.even { /* Changed from tr.even td */
  background: #F1F5FA;
}

tr.odd { /* Changed from tr.odd td */
  background: #fff;
}

tr.error {
  background: #FFCCCC;
}

tr.ok {
  background: #DDFFDD;
}

tr.drag {
  background: #FFFFDD;
}

tr.drag-previous {
  background: #FFFFF0;
}

Note the changes for the tr.even and tr.odd classes (removing the td). The last four rules are essentially just repeats of Drupal default CSS, but they need to be repeated after the tr.even and tr.odd declarations to prevent them from being overriden.

najibx’s picture

najibx commented

hi what do you make of this :
table settings created in FCKEditor is overiden by theme's CSS - http://drupal.org/node/300197

ludo1960’s picture

ludo1960 commented

Yikes!

I've got:

table {
width: 100%; // THIS CAUSE THE ALL TABLE BECOME 100%
}

In my Framewrork theme! And I'm just about to whack in some dramweaver tables, should I pull my hair out too?

andregriffin’s picture

andregriffin commented
Status: Active » Closed (fixed)

Thanks for the input everyone. I've fixed many of these problems in the upcoming Framework 2.5.

ludo1960’s picture

ludo1960 commented

And more importantly, thanks to you andre for a great theme, from all of us!