Wrong table name in query text and more...
shp - April 5, 2009 - 17:35
| Project: | Leftandright - Nested Set Taxonomy |
| Version: | 6.x-1.7 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | shp |
| Status: | active |
Jump to:
Description
1. "leftandright.module", line 145, should be "... FROM {term_data} ..."
2. "leftandright.info", line 1 and "leftandright.module", line 2: wrong version number
Also, some suggestion for code reorganisation. If you copy "leftandright" directory to /sites/all/modules/ but forget to delete the "taxonomy.module" file from it, you will have an error while enabling module (/admin/build/modules). Perhaps it would be better to place file "taxonomy.module" out of "leftandright" directory, e. g. leftandright-6.x-1.7.tar should contain:
leftandright/
landr
leftandright.info
.....
taxonomy.module
Best regards, shp
#1
Update:
leftandright-6.x-1.7.tar should contain:
1. leftandright/
1.1 landr
1.2 leftandright.info
.....
2. taxonomy.module
#2
Update 2:
1. leftandright.functions.inc, lines 8, 39, 40 - the same error with tablenames.
2. leftandright.rebuild.inc, line 17 - it's better to parse $db_url['default'] or $db_url, instead of only variant ($db_url), as Drupal can use more than 1 database connection.