In the Drupal 6 branch of Nodequeue, you see a handy nodequeue_load_nodes function which will load the nodes in the queue, without rendering them. This function doesn't exist in the Drupal 5 version. We really should keep the API the same between both the Drupal 5 and 6 branches, so lets add that function........

Comments

robloach’s picture

Status: Active » Needs review
Issue tags: +backport

Updated status.

ezra-g’s picture

This was intended as a replacement to nodequeue_nodes, since rendering nodes in this function was unnecessary. However, making this change between 5 and 6 caused some confusion. I've spent some time already indicating the difference between this part of the Nodequeue 5 and 6 APIs, so if we add this to Nodequeue for Drupal 5, I would appreciate if you also made the relevant changes to the documentation and the readme ;).

robloach’s picture

Assigned: Unassigned » robloach
StatusFileSize
new2.6 KB

Good call! The function signature of the nodequeue_load_nodes function now matches that of the Drupal 6 version. Also adds the documentation in README.txt.

ezra-g’s picture

Status: Needs review » Needs work

Hi Rob,

I'm sorry about any confusion, but what I meant in my original reply was that we could have both kinds of functions -- nodequeue_nodes and nodequeue_load nodes. This change between the D5 and D6 version caused a lot of confusion with some developers, so rather than make this API change in the Drupal 5 branch, I'd support adding an additional function, not replacing the existing one.

Thanks for taking the time to reroll the patch!

robloach’s picture

That patch doesn't replace the existing function, it simply adds a new function, and makes the original rendering function use it. If people get confused, then they can read the documentation that comes with it ;-) . Both the API and the functionality for nodequeue_nodes stays the same, there's just an added new nodequeue_load_nodes function, like you suggested ;-).

ezra-g’s picture

Status: Needs work » Closed (won't fix)

Drupal 5 is no longer a supported core version.