The attached patch provides SQL Server support to Workflow. It patches two major pieces: 1) The .install file, and 2) A UNION query that has ORDER BY statements for each UNIONed query. MSSQL requires that only one ORDER BY be done on the entire UNION as a whole. I'm not sure if this poses issues for MySQL and PostgreSQL, so please let me know. I wanted to avoid making MSSQL-specific exceptions in code if it could be avoided.

CommentFileSizeAuthor
workflow-mssql.patch5.63 KBpcorbett

Comments

NoRandom’s picture

NoRandom commented

Hi, pcorbett.

Could be this issue http://drupal.org/node/442864 related to your patch? I don't know anything about mysql, it's just a supposition.

pcorbett’s picture

pcorbett commented

Um, I don't think so. My patch involved the UNION and there is no UNION in http://drupal.org/node/442864. My patch wasn't fixing an error per se, it was just adjusting the query to work with more databases. Does that make sense? So, I don't think http://drupal.org/node/442864 is related to what I was posting the patch for.

deekayen’s picture

deekayen commented
Status: Active » Needs work

I know you're trying to put queries in blocks for readability, but that's non-standard for Drupal scripting. At a minimum, I'm sure the one-line queries should be $result = db_query("SELECT ...");

deekayen’s picture

deekayen commented

On second review, I see John has previously used the queries in blocks, so nevermind about that.

What's left that I am more concerned about is the block at the top of the patch where there was a space added for "comm ent". Was that intentional?

pcorbett’s picture

pcorbett commented

Hmm, I'm not sure what that comment text is... it can be removed as far as I am concerned.

Bastlynn’s picture

Bastlynn commented
Status: Needs work » Closed (won't fix)

Hi,

With the release of Drupal 7, Drupal 5 is no longer receiving security updates, reviews, or development from many contributed modules. Since 5 is now considered a depreciated version, you really should seriously look into upgrading to Drupal 6 or 7. The newer versions of Drupal work better, have more support, and will be safer (literally! security patches!) for your website. We are currently working on a new release for Workflow to Drupal 7. In light of that, further support for Drupal 5 issues is infeasible at the moment. Please consider upgrading to Drupal 6 or 7 in the near future - you'll be glad you did.

- Bastlynn