[NOT SOLVED] Hierarchical menu, NOT expaning to current term

I saw this issue also. I think I may have accidentally fixed it when I was fixing another issue. Please download the dev dated after this post and let me know.

Thanks,
Neil

I have the same problem with latest dev version.
The problem only appears with Menu Path: Hierarchy, Custom Path seems to be ok.

When "autoexpand" option is disabled only vocabulary will be shown (item for vocabulary enabled) and first term level expands when clicking on vocabulary. Other deeper levels are not shown.

Ok. I'll retest with the Hierarchy path.

I was also able to reproduce this in version 2.3. When is the last time that the hierarchy path worked correctly?

There is an interesting behaviour that I can see also with "Menu Path: Custom".

Mmh - how can I explane it..

Settings in TM: "Menu Path: Custom" / "Display Depth in Custom Path: 1" so two arguments get passed to the view.

1) When I use for VIEWS page "path = category/%" (just one %) I get two different results:
1a) "Auto Expand" is enabled: Whole menu shows up
1b) "Auto Expand" is disable: Only vocabulary item shows up (or first hierarchy level when "item for vocabulary= disabled)

2) VIEWS page path = category/%/% (two %)
2a) With this path the menu shows up correctly no matter if "Auto Expand" is enabled or disabled.

Considering this behaviour the path for "Menu Path: Hierarchy" should be category/%/%/%/% (VID/TID/TID/TID) when having three hierarchy levels.

The following is happening:

3a) path = category/% / Auto Expand" is enabled: Whole menu shows up
3b) path = category/% / Auto Expand" is disabled: Only vocabulary and first level of terms show up (not expanded)
3c) path = category/%/%/%/% / Auto Expand" is enabled: only 3rd level
3d) path = category/%/%/%/% / Auto Expand" is disabled: only 3rd level (same as 2c)

So why this different behaviour?
For 2a) Both arguments are always there, so category/%/% fits for all cases.
For 3c+d) The number of arguments is only true for the third level of terms.

When directly typing an URL adress with category/vid/tid (like downloads/10/184) or category/vid/tid/tid it works fine with path=category/%. So this seems to be the right thing looking from VIEWS side.

I think the described problem has to do with menu_callback_for_free_hook_into_sth [:-)] and its ability to find an excisting path.

(I´m not sure if it gets clearer now after this whole comment)

Klaus
(Neil, how is TM3 doing? I have nearly completed my community side, without a single line of PHP programming myself - thanks to Drupal Community - I could realize much more than I expected in the beginning - most time I spent with checking modules - just the frontpage needs some more designing -
I´m experimenting with ddblocks to give it some touch of aliveness.)

Martijn, do you use VIEWS for your Hierarchy Path or how do you realize it?

Martijn, how many arguments you are using withing withing the view? What path?

I spend time time doing some debugging in the different situation above. What I could see, the data is being stored in same way in the menu_links table. All taxonomy menu does is save data to that table using the menu_link_save function. It does have something to do with how Drupal displays the menu but I'm not sure where yet. I haven't dug through the core menu code or searched through current bugs.

In Martijn's situation, the URL is changing but what is sent and processed by Drupal is still cateogry/vid/tid/tid and therefore the same way as any other view. I thought you had this working at one time? What happened?

That's strange. I don't remember ever having that feature in v2. I'll look back through my versions and see what changes have been made.

Go ahead and send it. Was that the custom module I put together for you?

Got it Martijn, I'm looking at it now.

Well, the version you sent me is the same as the dev. Shoot, I thought we were close. What version of Drupal Core are you running? Did it change? I know i updated to 6.1. I was going to go back and see if it's a difference.

Is this issue still active was there a solution?

this is still an issue. last tie mi was debugging it i got hit by the menu module. I need to look into this again. It's surprises me with 7K installs that people haven't complained more.

I wasted a day playing with this module today. If used a custom path for my own MENU_HOOK - i.e. a defined in hook_menu, then top level menu never expands. I assume this because it requires a view.

Ended up using the hooks to generate my own menu based on the MENU_HOOK already created ('products').

function xxxx_taxonomy_menu_delete(&$item) {
     $term =  taxonomy_get_term($item['tid']);
     if ($term->vid != 1) // product category
       return;
     $name = preg_replace("/ /i","-",$term->name);
     $path = "gallery/" . $name;
     menu_link_delete(null,$path);
    return;
}

function xxxx_taxonomy_menu_insert(&$item) {

  if ($item['tid'] == 0){
      $item['remove'] = true;
      return;
  }
 
     $term =  taxonomy_get_term($item['tid']);
     if ($term->vid != 1) // product category
       return;

     $plid = _get_mlid('products');
     $item['plid'] =  $plid;
     $desc = $term->description;
     trim($desc);
     $desc = (strlen($desc) >0)? $desc : $term->name;
     $path = "gallery/" . preg_replace("/ /i","-",$term->name);
     $menu = array("link_path" => $path,
                   "link_title" => $desc,
                   "menu_name" => "navigation",
                   "router_path" => "gallery",
                   "weight" => $term->weight,
                   "plid" => $plid                 
                   );
  
     $result =menu_link_delete(null,$path);
     $result =menu_link_save($menu);
     $item['remove'] = true;
}

Hello bluffit, I'm glad you got it working. That is a very creative workaround.

When I have extra time, this is my number one priority for this module.

I"m working on this and issue #514640: Duplication of terms on and off for the next few hours. I'll be on IRC if anyone wants to assist. indytechcook

After hours of debugging and research, it seems these are linked to issues with the core menu system.

#550254: Menu links are sometimes not properly re-parented
#149562: Menu module causes duplicate menu items
#566094: menu_tree_data() doesn't build proper hierarchy

Some of the times say they are for D7 but also apply for D6. I haven't tested any of the patches yet.

Hi

From what I saw of your code, it seems that you needed to be able to allow a router path for custom module functions (not just views). If this was done, and the parent able to be specified properly, it should work.

As you can see from the code above, I can generate the correct menus from the available data ...?

Thanks for the suggestion bluffit. The router path 'taxonomy/term/%' does exist for the menu links. If it didn't , then none of the menu items would show for the path type. The issue is reproducible using the default path type also.

All of the data is stored correctly in the menu_links table. I've done several comparisons to workflows that work and others that don't. Even after rebuilding the menu, the rows in the menu_links table are correct. If the router path didn't exist, then the row would have been deleted.

I've debugged where the issue is at. The menu tree variable isn't been created correctly in the menu_tree_data/_menu_tree_data function in menu.inc of core. I've narrowed down the issue to those function, I just haven't had an opportunity to debug any farther.

The function _menu_find_router_path would find the correct router path, but this is already called from menu_link_save.

The issue is very easy to reproduce. Just select "use 'all' at the end of the url' You don't even have to use taxonomy_menu. I had issues adding taxonomy/term//all via a menu link manually on admin/build/menu. I know the router item exists because you can go to the page and it returns data (with or without the view enabled). They both use the same router path so I'm not sure why they both wouldn't work.

Don't get me wrong, I would love for that solution to work, I just don't think it will.

I found this issue when I was trying to get all the taxonomy terms to link to a single view with TermID argument.

The problem was fixed with this: http://drupal.org/node/292584#comment-1240468 -- adding a placeholder in the view's page display's path setting for the Term ID argument means that core menu system recognizes it as a path and expands the menu correctly.

Sunscribe, same problem here...

Hi all,

i got the same problem. i have taxonomy menu installed but it never expands after clicking it. so i installed the taxonomy_menu_trails as suggested but i still cannot make it work. here are my modules versions

• Taxonomy Menu 6.x-2.9
• Taxonomy Menu Trails 6.x-1.1

i have enabled

• Taxonomy Menu
• Taxonomy Menu Custom Path
• Taxonomy Menu Hierarchy
• Taxonomy Menu Trails

then i set the Taxonomy Menu Trails configuration as attached.... but still the menu doesn't expand and only the first level of taxonomy is shown.

Thanks,

I find that the problem maybe caused by my theme_menu_item_link() function in the template.php. sorry for the misleading.

This is a jquery workaround I came up with for now – (using menu block + menu trails + taxonomy menu modules). I set taxonomy menu to "Auto expand menu items" then used jquery to collapse based on active classes.

$(document).ready(function(){
	$(".menu-block-1 > ul > li > a.active, .menu-block-1 > ul > li > a.active-trail").parent().siblings().removeClass("expanded").addClass("collapsed").children("ul").css('display', 'none');
    $(".menu-block-1 a.active").parent().parent().parent().siblings().removeClass("expanded").addClass("collapsed").children("ul").css('display', 'none');  
}) 

Subscribing.

Have some problems with this too....

Somehow my problems go away when I use the Edit term module to set menu items and paths. You can find the module here:
http://drupal.org/project/edit_term

Not a very easy path though, it creates quite a lot of problems on the way and which can be resolved by adding the path manually, making sure the menu settings are correct and rebuilding the menu quite some times. I use 1 vocabulary with "Per language terms".

You can see the result here:
www.dinilu.nl
www.dinilu.eu

Perhaps this issue is from same reason of the issue below.

Custom menus never receive an active trail
http://drupal.org/node/942782

@PineRay, yes, I just came to post that resolution. I simply stuck the tax menu under Navigation and all was happy.

The Drupal 6 version is no longer supported