extra ">" characters showing up in tables

Posted by jjkiesch on April 7, 2009 at 5:52pm

5 followers

Issue Summary

i'm not sure if it was intentional but after upgrading draggable views a while back i started seeing ">" symbols on all of the table cells. i took them out and have a diff attached.

Attachment	Size
draggableviews-view-draggabletable.tpl_.php_.diff	1.38 KB

Comments

#1

Posted by sevi on April 8, 2009 at 12:14pm

Hm, strange.
But the problem must be somewhere else because the tags would not be closed without the ">".

#2

Posted by dalejung on April 8, 2009 at 3:22pm

Sevi,

The issue is that the tpl has <? and not <?php

Just replace those and it'll be fine. Might be why you might not see them.

#3

Posted by dalejung on April 8, 2009 at 9:13pm

Sevi, do you need me to post a patch or did my one liner make sense?

#4

Posted by jjkiesch on April 10, 2009 at 6:06pm

oops, i didn't see that it was the > for the closing html tag. i can confirm that adding the php fixes the issue

#5

Posted by sevi on April 13, 2009 at 10:22am

Normally your one liner would be enough. But I still don't understand what's going on here O_o. I've never heard before that there's a difference between <? and <?php. The templates of views module use <?php too.

Yes, please write a patch for me :)
And could you please explain it to me?

Greetings,
sevi

#6

Posted by dalejung on April 23, 2009 at 7:21pm

I will make a patch later. The issue was that the tpl was using <? and NOT <?php. Not all webservers are configured to trigger php processing from <? ?> tags. Actually, most servers I've been on only recognize <?php ?> as php.

-      <tr class="draggable <?php print $zebra; ?><? if ($draggableviews_extended[$count]) print ' '. 'draggableviews-extended'; ?><? if ($tabledrag_type[$count]) print ' '. $tabledrag_type[$count]; ?>">

You will notice that after the print $zebra you're using a <?.

#7

Posted by sevi on April 25, 2009 at 12:53pm

Oh, ok. I thought you want me to use <? instead of <?php. You're right. I haven't noticed that I use <? in my template.
I don't need you to write a patch for me :)

I'll commit this immediately.

Greetings,
sevi