hook form_alter rewrite
erbzh - April 8, 2009 - 02:04
| Project: | CCK Field Privacy |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Description
Hi,
Experienced isses with CCK Field Privacy v. 6.x-1.1-dev, some already related,
This patch should fix some issues related with fieldgroups/fieldset/tabs and some field types not already handled.
Also fixes some issues with Content Profile at registration.
This patch shouldn't be used as is and needs work, it's just here for dev purpose
In particular, does not fix fiedgroup permission precedence over inside fields permissions.
| Attachment | Size |
|---|---|
| cckfp_hook_alter.patch | 13.46 KB |
#1
Thanks for the patch - I noticed the TODO comments & such, any ideas on improvements? You seem to have a great grasp of working with the intricacies of CCK's fields, so any additional info you have would save me a great amount of time.
I rerolled with some whitespace/tab changes. There are a few other whitespace changes from other parts of the file (string concatenation, etc) that can go along with this. Any input others can provide would be great.
Thanks,
Bryan
#2
Tested locally and haven't found any issues yet, so I'm changing the status to NR. I've also rerolled the patch to make sure there's not any issues with the patch in #350899: Padlocks not displaying in fieldgroups, so that both sides of the fieldgroups issue can be solved.
Bryan
#3
Committed to CVS, will show up in the next development release. Please test out the new version to make sure there aren't any issues that come up before I make a new release.
Bryan O'Shea