HEAD version

This version will change ;)

CommentFileSizeAuthor
#14 russian_services_vkontakte.tar_.gz1.27 KBIngumsky
#10 service_links.zip12.82 KBpvasili
#8 service_links.zip11.97 KBpvasili
#7 warning2.png10.34 KBpvasili
#6 warning.png7.86 KBpvasili
#2 service_links.zip10.04 KBpvasili
service_links.zip9.96 KBpvasili

Comments

TheCrow’s picture

TheCrow commented

Ehi pvasili great work, just some detail to fix:

 $links['LinkStore'] = array(
    'link' => 'http://www.linkstore.ru/servlet/LinkStore?a=add&url=<encoded-url>&title=<encoded-title>',
    'name' => 'ru_LinkStore',
    'description' => t('Bookmark this post on LinkStore'),
  );

  //must be... after exchange id and name

 $links['ru_linkstore'] = array(
    'link' => 'http://www.linkstore.ru/servlet/LinkStore?a=add&url=<encoded-url>&title=<encoded-title>',
    'name' => 'LinkStore',
    'description' => t('Bookmark this post on LinkStore'),
  );

because the first is used for generate images... (using ru_linkstore for link images (ru_linkstore.png)... everyone want delete russian service will do it easy (del ru_* or rm ru_*) ) and the second is used as text for textual links (better have Linkstore than ru_LinkStore).

If you agree i'll change it automatically through VIM without pass service by service :))

P.S. Why the last 3 are commented?

pvasili’s picture

pvasili commented
StatusFileSize
new service_links.zip10.04 KB

1) $links['ru_linkstore'] - I agree with you.
2) 'name' => 'LinkStore' - This is bad because I can easily see only Russian bookmark at /admin/settings/service_links/services :(.
Another option - add a field on the page /admin/settings/service_links/services - Servise.
The data for the field taken from Info file (forward_services.info [name] for example) Servise = Forward Services)
and I will see:

========================
Service Name                    Servise             Show
Share this on Twitter          General Services      x
Russian Services               Russian Services      х
...
========================

3) 3 comment - ToDo ;)

TheCrow’s picture

TheCrow commented
Assigned: pvasili » TheCrow

wow the "another option" of second point is great!!! i'll work on it :))

Thank you!

TheCrow’s picture

TheCrow commented
Assigned: TheCrow » Unassigned
Status: Needs work » Fixed

Russian services and Service column committed, they will appear in the next auto-generated dev release :))

pvasili’s picture

pvasili commented
Component: Miscellaneous » Code
Status: Fixed » Needs work

1) ottimo, grazie!

2)
==========================
italian_services.module on line 32
'name' => 'Segnalo.com' -> 'name' => 'Segnalo.com',
italian_services.module on line 38
'name' => 'TechNotizie' -> 'name' => 'TechNotizie',
==========================
errori di battitura ;)

pvasili’s picture

pvasili commented
StatusFileSize
new warning.png7.86 KB

4)

pvasili’s picture

pvasili commented
StatusFileSize
new warning2.png10.34 KB

I made a wrong comment. (delete it)...

pvasili’s picture

pvasili commented
StatusFileSize
new service_links.zip11.97 KB

+ 2 Service
minor bugfixes

TheCrow’s picture

TheCrow commented
Status: Needs work » Fixed

Committed: Comma fix in italian_services, the new russian_services, the double underscore is single now!

About the second image... ru_Vaau is the old system you must see just Vaau in the new... maybe is mixed?

Thank you again for collaborate ;))

pvasili’s picture

pvasili commented
Assigned: Unassigned » pvasili
Status: Fixed » Reviewed & tested by the community
StatusFileSize
new service_links.zip12.82 KB

+ 1 Service

TheCrow’s picture

TheCrow commented

About Linksia are u sure the link is: http://links.i.ua/mark/?url==<encoded-url>&ename=<encoded-title> and not http://links.i.ua/mark/?url=<encoded-url>&ename=<encoded-title> ?
(watch the '=' near 'url')

TheCrow’s picture

TheCrow commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Ingumsky’s picture

Ingumsky commented
Status: Closed (fixed) » Needs review
StatusFileSize
new russian_services_vkontakte.tar_.gz1.27 KB

I've created a patch for the russian_services.module which implements a bookmark for vkontakte.ru website and fixes a broken link for yandex.ru. The patch mentioned is attached to this comment.

pvasili’s picture

pvasili commented

Ingumsky - excellent job, thanks.

TheCrow’s picture

TheCrow commented
Assigned: pvasili » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.