russian services
pvasili - April 8, 2009 - 07:02
| Project: | Service links |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | pvasili |
| Status: | closed |
Description
HEAD version
This version will change ;)
| Attachment | Size |
|---|---|
| service_links.zip | 9.96 KB |
#1
Ehi pvasili great work, just some detail to fix:
$links['LinkStore'] = array(
'link' => 'http://www.linkstore.ru/servlet/LinkStore?a=add&url=<encoded-url>&title=<encoded-title>',
'name' => 'ru_LinkStore',
'description' => t('Bookmark this post on LinkStore'),
);
//must be... after exchange id and name
$links['ru_linkstore'] = array(
'link' => 'http://www.linkstore.ru/servlet/LinkStore?a=add&url=<encoded-url>&title=<encoded-title>',
'name' => 'LinkStore',
'description' => t('Bookmark this post on LinkStore'),
);
because the first is used for generate images... (using ru_linkstore for link images (ru_linkstore.png)... everyone want delete russian service will do it easy (del ru_* or rm ru_*) ) and the second is used as text for textual links (better have Linkstore than ru_LinkStore).
If you agree i'll change it automatically through VIM without pass service by service :))
P.S. Why the last 3 are commented?
#2
1) $links['ru_linkstore'] - I agree with you.
2) 'name' => 'LinkStore' - This is bad because I can easily see only Russian bookmark at /admin/settings/service_links/services :(.
Another option - add a field on the page /admin/settings/service_links/services - Servise.
The data for the field taken from Info file (forward_services.info [name] for example) Servise = Forward Services)
and I will see:
========================Service Name Servise Show
Share this on Twitter General Services x
Russian Services Russian Services х
...
========================
3) 3 comment - ToDo ;)
#3
wow the "another option" of second point is great!!! i'll work on it :))
Thank you!
#4
Russian services and Service column committed, they will appear in the next auto-generated dev release :))
#5
1) ottimo, grazie!
2)
==========================
italian_services.module on line 32
'name' => 'Segnalo.com' -> 'name' => 'Segnalo.com',
italian_services.module on line 38
'name' => 'TechNotizie' -> 'name' => 'TechNotizie',
==========================
errori di battitura ;)
#6
4)
#7
I made a wrong comment. (delete it)...
#8
+ 2 Service
minor bugfixes
#9
Committed: Comma fix in italian_services, the new russian_services, the double underscore is single now!
About the second image... ru_Vaau is the old system you must see just Vaau in the new... maybe is mixed?
Thank you again for collaborate ;))
#10
+ 1 Service
#11
About Linksia are u sure the link is:
http://links.i.ua/mark/?url==<encoded-url>&ename=<encoded-title>and nothttp://links.i.ua/mark/?url=<encoded-url>&ename=<encoded-title>?(watch the '=' near 'url')
#12
#13
Automatically closed -- issue fixed for 2 weeks with no activity.