Posted by dicreat on April 8, 2009 at 9:58am
| Project: | Legal |
| Version: | 6.x-2.2-beta4 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Hi.
I think, that link to "Terms & Conditions" must be translated. I've been change l('Terms & Conditions', 'legal') to l(t('Terms & Conditions'), 'legal') and it's work fine. Please review patch.
| Attachment | Size |
|---|---|
| legal.module.patch | 1.12 KB |
Comments
#1
Patch works fine.
#2
Generally speaking is a non sense to send the whole legal text throght the locale translation system. Locale should be used to translate arrays but not huge pieces of text as the legal page usually is. But, well, this is the solutions I've also used for the last two years.
When we'll have a really multilingual solution on such an important module as legal is? When a text box for every active language?
#3
This patch ist just about the link title, not the whole text.
Multilinguality of the legal text should be a different issue.
The attached patch replaces the tabs with spaces, everything else is well.
Please commit!
#4
Thanks for the patch, it works perfectly.
Is it going to be added to the next version ? I don't know how patch submission works.
Please commit :-)
#5
Not to muddy the waters, but my patch would fit right in. The page titles also should be translated. This simply wraps the page titles with t() for "legal", "admin/settings/legal" and "legal_accept". Nothing more!
#6
Commited #3.
#5 is not needed in Drupal 6.
Thanks!
#7
Automatically closed -- issue fixed for 2 weeks with no activity.