Hi.

I think, that link to "Terms & Conditions" must be translated. I've been change l('Terms & Conditions', 'legal') to l(t('Terms & Conditions'), 'legal') and it's work fine. Please review patch.

CommentFileSizeAuthor
#5 legal_translate_fix.patch963 bytestechninja
#3 legal.module_2.patch1.13 KBsanduhrs
legal.module.patch1.12 KBdicreat

Comments

neochief’s picture

neochief commented
Status: Needs review » Reviewed & tested by the community

Patch works fine.

jorditr’s picture

jorditr commented

Generally speaking is a non sense to send the whole legal text throght the locale translation system. Locale should be used to translate arrays but not huge pieces of text as the legal page usually is. But, well, this is the solutions I've also used for the last two years.

When we'll have a really multilingual solution on such an important module as legal is? When a text box for every active language?

sanduhrs’s picture

sanduhrs
he/him
Primary language German
Location 🇪🇺 Heidelberg, Germany, Europe
commented
StatusFileSize
new legal.module_2.patch1.13 KB

This patch ist just about the link title, not the whole text.
Multilinguality of the legal text should be a different issue.

The attached patch replaces the tabs with spaces, everything else is well.
Please commit!

flips’s picture

flips commented

Thanks for the patch, it works perfectly.

Is it going to be added to the next version ? I don't know how patch submission works.
Please commit :-)

techninja’s picture

techninja commented
StatusFileSize
new legal_translate_fix.patch963 bytes

Not to muddy the waters, but my patch would fit right in. The page titles also should be translated. This simply wraps the page titles with t() for "legal", "admin/settings/legal" and "legal_accept". Nothing more!

recidive’s picture

recidive commented
Status: Reviewed & tested by the community » Fixed

Commited #3.

#5 is not needed in Drupal 6.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.