Closed (fixed)
Project:
FLV Media Player
Version:
6.x-1.0-beta3
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
8 Apr 2009 at 10:50 UTC
Updated:
19 May 2009 at 07:40 UTC
Jump to comment: Most recent file
Comments
Comment #1
mrfelton commentedI set the path as an absolute path to get around this, which works, except for in this case #441552: path to skin contains path prefix on multilingual sites
Comment #2
arthurf commentedI'm not quite sure how to handle this- perhaps paths to skin and plugins need to be parsed the same way that the url to the player is? It seems a bit dangerous to me, but not quite sure what to do... any suggestions?
Comment #3
mrfelton commentedI would say, yes - parse the path to the skin in the same way as the player. There should definitely be a way to specify a path relative to the doc root, and have it prepend the domaim name automatically, just like we can do for the player path. Why do you say it seems a bit dangerous?
Comment #4
mrfelton commentedAttached is a patch which applies the same url parsing to the player skin path as to the player path. It doesn't make any modifications to the textfield description to let the user know this will happen - it simply changes the backend functionality.
Comment #5
mrfelton commentedComment #6
arthurf commentedI think you got your patch reversed here. I've added the check for the skin parameter. The other thing that needs to be considered are the plugin urls, but I'm not sure really how to handle that- I don't know enough about flash's crossdomain policy to know if having those paths hard coded is an issue. I've committed the fix
Comment #7
mrfelton commentedBare in mind that plugins are not always local :- The longtail ad solution plugin for example, requires the following settings to work:
To get this to work, I had to a) override theme_swfobject_api to get it to output two divs (this is actually a requirement of SWFObject 2 now I believe). and b) add the custom flashvars and params to that theme function, as that section of the admin interface (external config?) wasn't working