The tag part

!time

should be changed to
!time

because div is forbidden in that context under some doc types

It needs perhaps some more changes because the output with is a bit different as with div.

Comments

icecreamyou’s picture

icecreamyou commented
Assigned: Unassigned » icecreamyou
Priority: Normal » Minor
Status: Active » Postponed (maintainer needs more info)

It looks like you intended some HTML tags to be included in that request that didn't make it through the filter. Can you explain better?

The styling is not going to change in 1.x with 2.x so close, but if there is a legitimate concern with some code I will fix it.

michtoen’s picture

michtoen commented

Oh, sorry

Its line 1267 and 1270: the

In the other parts of the code the submitted part is already taged with span, only
in that lines not.

icecreamyou’s picture

icecreamyou commented

...

Use &gt; for a right angle bracket and &lt; for a left angle bracket or surround your HTML with <code> tags.

michtoen’s picture

michtoen commented

Hm, strange... i even not used a real tag

its the div class = "submitted" part in both line - it should be span = like in the other code parts.

icecreamyou’s picture

icecreamyou commented
Status: Postponed (maintainer needs more info) » Closed (works as designed)

That's intentional because in the module that function is only called when displaying lists and it looks better to have the time separate. It's a theme function though so you can override it if you need it changed, or just change the way it displays with CSS.

michtoen’s picture

michtoen commented

Hm, not sure i understood.

You get under xhtml a style warning because you created a div inside a span, which is invalid css for xhtml strict at
last. That happens for example if you dispay the "recent status block". Try it with firefox, xhtml strict doctype and
html validator add-on. So, its nothing you can fix with css.

Its not a big issue, right - but drupal with that little fix will validate fine.

would it not be the right way to use span and then something like display:block or such to force a line break without a br?

icecreamyou’s picture

icecreamyou commented
Status: Closed (works as designed) » Active

Ah, okay. I didn't understand that that's what the problem was. I'm on vacation and won't be back until Sunday night but I'll fix it then.

icecreamyou’s picture

icecreamyou commented
Title: style problem in theme_facebook_status_item » XHTML validation in theme_facebook_status_item
Status: Active » Fixed

Fixed in dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.