In discussion with michaelfavia in IRC, the question came up:

Why is 'Settings' the default tab instead of 'Domain list'?

I don't really have an opinion here. What would everyone prefer? Which tab do you use more often?

CommentFileSizeAuthor
#3 427854-domain-tab.patch1.67 KBagentrickard

Comments

michaelfavia’s picture

michaelfavia commented

domains should be edited and created as a primary task and settings should be "set and forget". This is in my opinion a good argument for domain list like every other module (og, views, etc)

nonsie’s picture

nonsie
she/her
Primary language Estonian
commented

Good point. One shouldn't really mess with settings after it has been set up.
In my case I use batch updating the most but it doesn't make sense to set this as the default tab.
+1 for domain list

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
StatusFileSize
new 427854-domain-tab.patch1.67 KB

Here is the patch. It does make me wonder if we need to re-organize the menu structure in the admin.

For example, right now we use:

domain/edit/%domain
domain/delete/%domain

When we should probably use:

domain/%domain/edit
domain/%domain/delete

And so on. But this is a fairly large change.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs review » Patch (to be ported)

Apparently I committed this on 12-APR.

michaelfavia’s picture

michaelfavia commented
Status: Patch (to be ported) » Fixed

fixed then or did you want to port to 5 for some reason?

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Fixed » Patch (to be ported)

I have been consistently marking things as 'to be ported' to the 5 version, but it is doubtful that the backports will happen. So I am going to put it as 'to be ported'.

If someone really wants to upgrade the D5 version, that status is a guide.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Patch (to be ported) » Fixed

Backported.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.