hook_link and hook_nodeapi problems

On hook_nodeapi('view') the module should inspect and respect $node->build_mode

It's doing on hook_nodeapi stuff that would normally be done in hook_link, as there are two options on where to insert the link:

1. Normal link area: uses code in hook_link
2. Content corner: uses code in hook_nodeapi (which looks very similar to the code in hook_link indeed).

In D7, hook_link was abolished and I was able to simplify that code A LOT. If someone would wish to backport the hook_link banishment to D6, I would be more than happy to backport the simplification also. Until then, there's nothing that can be done about it.

As to build_mode, that was tried, merged and created enough problems (#349991: Use node build_mode instead of custom property for customizing node fields) that I reverted the patch. I am marking this as a duplicate because I would rather that issues related to build_mode be followed in that thread.

Please file specific issues if there's actually any bug that I can try to reproduce/fix.

João

I was writing my reply while pwolanin actually provided some information. I will take a look at it.

João

How can I test this problem?

I have added the following conditions to the 'view' operation in the print_nodeapi calls:

isset($node->build_mode) && $node->build_mode == NODE_BUILD_NORMAL

But I have been unable to find a case where I can test if this is doing anything useful.

João

If you put that condition, the link should no longer be added on previews.

That's the problem.. I can't see the link in previews even without that condition..

Also, what you are doing in print.pages.inc looks funny. On line 556 you have.

  //alert other modules that we are generating a printer-friendly page, so they can choose to show/hide info
  $node->printing = TRUE;

however, you should use the build mode already provided by core:

modules/book/book.module:943:  $node->build_mode = NODE_BUILD_PRINT;

@pwolanin: please note that the $node->printing flag is ancient (I think it was pre-Drupal 5).

The use of build_node is sufficiently new that for instance moshe weitzman submitted a patch in which the build_mode would be 'print' (#349991: Use node build_mode instead of custom property for customizing node fields).

While studying my reply to your comment in #1, I had also reached the conclusion that I should indeed define build_mode as NODE_BUILD_PRINT. Anyway, it's nice when someone that knows core Drupal a lot better than I do confirms that it is the correct mode.

Thanks,

João

Code to use build_mode in hook_nodeapi has just been committed.