Add does not expire when maximum clicks reached [#428772]

Comment #1

jeremy commented 9 April 2009 at 12:56

Status:

Active

» Postponed (maintainer needs more info)

Are you using the ad_cache_file module? Does the ad expire after cron runs?

Log in or register to post comments

Comment #2

majdi commented 2 January 2010 at 06:50

I have same problem
the ad don't switch status when its reach maximum clicks or impressions

No I dont use ad_cache_file

and also it's don't expired after cron run
thanks

Log in or register to post comments

Comment #3

majdi commented 2 January 2010 at 07:44

Status:

Postponed (maintainer needs more info)

» Needs review

Log in or register to post comments

Comment #4

Uvedale commented 25 October 2010 at 17:48

I experienced this problem too.

I needed a quick fix for click expiry, so I added this code to the ad_redirect function in the ad.module file after the new click had been added:


     $maxclicks = db_result(db_query("SELECT maxclicks FROM {ads} WHERE aid = %d", $aid));
  if ($maxclicks > 0) {
          $totalclicks = db_result(db_query("SELECT COUNT(*) FROM ad_clicks WHERE aid = %d AND status = %d", $aid, 1));
          if ($totalclicks >= $maxclicks) {
                db_query("UPDATE {ads} SET adstatus = 'expired', autoexpire = 0, autoexpired = %d, expired = %d WHERE aid = %d", time(), time(), $aid);
          }
  }