Attached is a patch to document taxonomy_save_vocabulary. I'm quite new at creating patches, so any feedback on whether it's correct, and if not, what to change, would be much appreciated.

CommentFileSizeAuthor
taxonomy_save_vocabulary_doc.patch1.9 KBchriscohen

Comments

davidwhthomas’s picture

davidwhthomas commented

Please commit this, there's no documentation on that function at the moment and this is v.useful.

beautifulmind’s picture

beautifulmind
he/him
Primary language Gujarati
Location Dubai
commented

Thanks. I just wanted to make one thing clear and that what you did for me. Thanks a lot pal!

thedavidmeister’s picture

thedavidmeister commented
Version: 6.10 » 6.x-dev
Status: Needs review » Needs work

patch no longer applies.

error: taxonomy/taxonomy.module: No such file or directory

We have trailing whitespace issues here, indentation is wrong. We say "associative array" instead of "keyed array".

No need for AND and DELETED to be capitalized in the first paragraph.

chriscohen’s picture

chriscohen commented

No offence mate but just fix it and apply it already. I wrote this in 2009 so of course it's going to be out of date.

I have long since given up offering my patches on documentation because every single one ends up having nothing done about it, even years later, so I am not going to rewrite this one.

I do appreciate your last update however, so thanks for the input.

thedavidmeister’s picture

thedavidmeister commented
Status: Needs work » Closed (won't fix)

No offence mate but just fix it and apply it already.

I don't have any more ability to apply patches directly to core than you do.

I am not going to rewrite this one.

I will close this then, the function in question does not exist in D7+ and if I re-roll the patch I won't be eligible to RTBC it and it doesn't look like anybody else is interested in moving this along.

Thanks anyway for the original patch.