When you have more than one theme enabled, on the 'user/$uid/edit' page, the system name of the theme is used and the file location of the theme as description. Should be the human-readable name and proper description in my opinion, like it is on the admin-page. The system-path is no info normal users should see.
A problem is that Garland sais '(default)' in it's info-file and the description will mention the '(site default theme)'. I suggest to remove '(default)' from Garlands description but did not do that in this patch. Another option is to remove the description on the user-page but personally, I like some description there although I'm not too happy with the current ones as it is a bit technical.
Also, the color.module didn't alter any screenshots for re-colorable themes; affects 'admin/build/themes' as well.
At last, if the 'site default theme' is chosen, an empty string must be saved, but the solution as it is now gives notices so I moved that part to the hook 'system_user_save'. Was also necessary to have a proper key to alter the screenshots in color.module.
Patch and screenshots attached. Cache must be cleared to test the patch because it adds new functions.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | theme-select-3.patch | 5.86 KB | desbeers |
| user-theme-after.png | 62.42 KB | desbeers | |
| user-theme-before.png | 50.15 KB | desbeers | |
| theme-select-2.patch | 5.78 KB | desbeers |
Comments
Comment #2
desbeers commentedOops, notices when only one theme available. New patch attached.
Comment #3
dries commentedThe new UI is an improvement. However, now the end-user UI mentions the Drupal.org theming guide. That sounds like a bad idea ...
So I'm wondering though, is this the kind of feature that we should remove from Drupal core? How many non-Drupal websites do you know that allow you to change themes?
Comment #4
catchThere's an issue somewhere for removing the UI for multiple enabled themes from core - this would presumably be a part of that.
Main question is would we remove the theme column from {users} and require a contrib module to handle its own storage, or leave it there and just move the UI to contrib?
Comment #5
dries commentedEither storage alternative works for me -- at this point. History learns us that we end up moving the storage mechanism out 1-2 years later anyway. ;-)
Comment #6
desbeers commentedThe issue for for removing the UI for multiple enabled themes is #292253
I actually started this patch because the color.module didn't alter the screenshot in the admin and checked the user-form; thought it was a bit ugly, gave a notice and didn't alter the default theme.
I postpone this issue awaiting the outcome of the discussion to remove the UI for users because if so, this patch will be just a few lines for the color.module.
Comment #7
Tor Arne Thune commentedWell, since this feature was removed in Drupal 7, I'm closing it as won't fix.
See #292253: Remove the per-user themes selection from core.