Maximum Quantity Patch

Very cool. I will take a look. Thanks.

Thanks.

Looks good. I am going to modify it to have a flag to turn this on and off. I think this will be less confusing for other user. I should have this ready in about 2 hours (I have some other changes to make too).

I changed the code from:
$order_qualifying_amount > $discount->qualifying_amount_max
to:
$order_qualifying_amount >= $discount->qualifying_amount_max

That way if you have a discount that is $100-$200 (qualifying amount is $100, max qualifying amount is $200) and another that has a qualifying amount of $200, and a cart has exactly $200 worth of items, the cart will trigger the second discount reliably.

I am also not sure if we should show warnings on exceeding the max qualifying amount. It seems like the right behavior looking at the module as a whole but it might be confusing to a user. I'll leave the warnings in because this change is for you and I want it to work the way you need it.

Thanks again for the patch.

OK, beta 13 is ready.

I think that makes sense. Generally in programming you get a lot of [min, max) conditions. I was trying to avoid people having to put in $2/$2.99 but that may make more sense for the average user. Make that change on your system and I'll release a beta 14 with that change later tonight.

Looks like this has been committed for a while.

There is a major bug in this for 6.x.2.x-dev!

The lines starting at 199 have

$form["discount_set"]

which isn't declared until after the qualifying_amount_max array stuff, so of course it fails.

It needs to be changed to

$form["qualifications"]

I'll attach a patch for this later tonight.

Ran into the same issue for this version (after upgrading).

More detailed (thanx to #14):
Adjust the following lines in uc_discounts.admin.inc to:
199 $form["qualifications"]["qualifying_amount_max_header"] = array(
204 $form["qualifications"]["has_qualifying_amount_max"] = array(
215 $form["qualifications"]["qualifying_amount_max"] = array(
226 $form["qualifications"]["qualifying_amount_max_footer"] = array(

Is a patch already available?

Marking as active. It would be great if someone could roll a patch for the proposed change.

Patch

There is also an error on line 212 which is setting the maximum value variable. Instead of using the maximum_value, it is using the roles value.

Added the patch to my local install, took it just fine, doesn't seem to do anything... 2x-dev. Trying Qty say 6-11, and tried what was mentioned 2/3... nothing won't take.

Have tried latest 1x beta which adds the flag for max but can't figure out how to use it.
and
The 2x fails in about every way I have tried. Not sure if it was ever supposed to work.

Again, would love to see a new release.

since the previous items were for 1x, and the later were for corrections for 2x screwed up by 1x patches, could we focus on the 2x and someone roll the changes for a GOOD 2x full patch?

thanks.

here you go, this is for peeps wary of this story and the multiple patches. max.patch does work, this is merely the patched file and all you should need to get this working. This does not implement any change that #18 mentions as it works without. After working on so much of this I may ask to co-maintain soon. This is a very important module and so far the discounts framework I find severely lacking... but could be wrong.

Remove .txt off the end before adding obviously

This is indeed a very important module, and discount framework is indeed lacking, no offense intended to its coders or anything like that. I posted a message over on the UC forums earlier and I'll say it again here:

I had spent over 20 hours over the past month and a half trying to get some very simple, but very specific, discounts in an Ubercart store via conditional actions & the discount framework. They really couldn't be done. Once I stumbled upon Ubercart Discounts Alternative, I got them working in -- I kid you not -- 15 minutes.

That's my rant. Thanks for the patch -- adding "maximum quantity" gives this module nearly all of the limiters that it will need. I'm sure specific use cases will find a few more and get this thing to cover 95% of usage cases.

I think this module is great. But even after applying the patch in #22 I'm still having a problem.

I have set up a member price for something and limited the quantity available at that price to 2, and a member can only use the discount one time. But the discount appears in the cart for 2 items every time that member makes a purchase. So the module is honoring the initial quantity limit, but apparently not checking the member to see if s/he has already used the discount.

I have checked the members profile and the previous purchases are appearing in the order history.

I have done some further experimenting and found another problem. If the Discount Type is set to Fixed Amount Off and the Maximum Times Applied is set to 2 the discount is applied only 2x, even if the person orders more than 2 of the item. If the Discount Type is set to Fixed Amount Off per Qualifying Item and the Maximum Times Applied field is 2 the cart says it will apply the discount twice, but it actually applies the discount to the total number of items matching the SKU.

There may be a distinction I'm missing between Fixed Amount Off and Fixed Amount Off Qualifying Items, but I cannot figure out why it works one way and not the other. I would have expected to get a better result from the latter.

I still have not figured out why if the discount is set to be applied to a user only once it applies to the user every time s/he makes a purchase. IOW, I set Maximum Uses by User to 2 and Maximum Times Applied to 2. Each time User A makes a purchase s/he gets the discount on up to 2 of the items, despite having made a previous purchase.

This is so even after the most recent patch above.

Setting status to Needs Work based off comment above.

here's instructions on rolling a proper patch http://drupal.org/patch/create