Hello,
As a first try to familiarize myself with the Drupal engine, I tried to update your module for Drupal 4.7.
Here is the result of my work. It's not perfect, but it's working for me (4.7b2). I hope you can use my additions for your next release.
I wish you an happy new year!
Shiva Thomas, from Switzerland
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | user_badges_0.module | 23.38 KB | Patrick Nelson |
| user_badges.module | 23.27 KB | Shiva Thomas |
Comments
Comment #1
evilzenscientist commentedThere's a hard coded path in line 316:
Before:
316: $form['#action'] = '/drupal/?q=admin/settings/user_badges/images';
After:
316: $form['#action'] = '?q=admin/settings/user_badges/images';
That works for me - and assumes the drupal doc root.
Comment #2
Patrick Nelson commentedJust a heads-up to say that this patch no longer works against 4.7b4.
I'm going to take a look at it but would appreciate any help from the original poster.
Comment #3
Patrick Nelson commentedChanged title
Attached module
Now works
Not sure about line 316 for those people without clean URLs. Perhaps someone else knows...?
Comment #4
Patrick Nelson commentedI'm afraid I spoke too soon. The images tab is broken. Any ideas anyone?
Comment #5
Julien PHAM commentedThis patch does not work for users without clean urls...
Comment #6
heine commentedThere are multiple problems with the port. Good news though at http://drupal.org/node/70940#comment-117744
Focus:
- Implement 4.7 APIs (eg FAPI: define, validate, submit model)
- Fix bugs
Comment #7
heine commentedPatrick, thanks a lot. That saved a lot of tedious $form['something'] = array... typing :)
Comment #8
heine commentedOne note I forgot to add to the previous post.
user_badges now depends on upload.module
Comment #9
(not verified) commented