Hello,

As a first try to familiarize myself with the Drupal engine, I tried to update your module for Drupal 4.7.

Here is the result of my work. It's not perfect, but it's working for me (4.7b2). I hope you can use my additions for your next release.

I wish you an happy new year!
Shiva Thomas, from Switzerland

Comments

evilzenscientist’s picture

There's a hard coded path in line 316:

Before:

316: $form['#action'] = '/drupal/?q=admin/settings/user_badges/images';

After:

316: $form['#action'] = '?q=admin/settings/user_badges/images';

That works for me - and assumes the drupal doc root.

Patrick Nelson’s picture

Just a heads-up to say that this patch no longer works against 4.7b4.

I'm going to take a look at it but would appreciate any help from the original poster.

Patrick Nelson’s picture

Title: Update for Drupal 4.7b2 » Update for Drupal 4.7b4
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new23.38 KB

Changed title

Attached module

Now works

Not sure about line 316 for those people without clean URLs. Perhaps someone else knows...?

Patrick Nelson’s picture

Status: Reviewed & tested by the community » Needs work

I'm afraid I spoke too soon. The images tab is broken. Any ideas anyone?

Julien PHAM’s picture

This patch does not work for users without clean urls...

heine’s picture

There are multiple problems with the port. Good news though at http://drupal.org/node/70940#comment-117744

Focus:
- Implement 4.7 APIs (eg FAPI: define, validate, submit model)
- Fix bugs

heine’s picture

Status: Needs work » Fixed

Patrick, thanks a lot. That saved a lot of tedious $form['something'] = array... typing :)

heine’s picture

One note I forgot to add to the previous post.

user_badges now depends on upload.module

Anonymous’s picture

Status: Fixed » Closed (fixed)