If you edit the present domains subdomain or delete the present domain conditionally redirect the user to the primary domain after performing the operation if we cant determine that the new subdomain is a functional one, in which case redirect to it.

Comments

michaelfavia’s picture

Title: Check domain editing and deleteion steps for invalid domain and redirect to primary domain » Check domain editing and deletion steps for invalid domain and redirect to primary domain

Learn to type

agentrickard’s picture

For the reason we do this now, see issues like #429278: Sudomain and 404 Not Found. Not sure there is a graceful way to fix this.

Also note that batch operations typically must be performed from the primary domain, so we would need to address that as well.

michaelfavia’s picture

i would plan on refactoring batch and singular operations like drupal does with nod_load_multiple and node_load both functions remain with signatures intact but all logic offshored to the more complex one with simple arguments thrown in to it. Please see code referenced for details. We can also check for the presence of a signature that this install provides and actually ensure the DNS is setup before me let the site be marked active or something if wed prefer to go that route. Then you can create the items in advance and only enable them when it works.

agentrickard’s picture

That isn't really the issue, I don't think. The problem is that we need to pull some default values from the main domain -- and the easy way to do that is from the main domain.

But I think the new domain_set_domain() may fix that for us.

agentrickard’s picture

Version: 6.x-2.0-rc6 » 6.x-2.0-rc8
Status: Active » Postponed

This is a nice-to-have but not critical improvement.

agentrickard’s picture

Status: Postponed » Closed (won't fix)