When dealing with WKB, Geo checks the byte order but never references it--the unpack() operations use the byte order of the machine running the code.

Probably the only time this will ever "byte" anyone is if they're moving data between web servers and some trusty old PPC Mac... er, like me. This patch makes sure that Geo uses the byte order specified by the WKB, and reverses binary double data if the encoding byte order is different from the byte order of the machine the code is running on.

CommentFileSizeAuthor
#2 geo_byte_order_1.patch2.89 KBbecw
#1 geo_byte_order.patch2.72 KBbecw
geo_byte_order.patch2.72 KBbecw

Comments

becw’s picture

becw commented
StatusFileSize
new geo_byte_order.patch2.72 KB

Updated the patch to reflect recent Geo development.

becw’s picture

becw commented
StatusFileSize
new geo_byte_order_1.patch2.89 KB

Fixed a bug in the patch where two binary doubles were treated as one string rather than two.

A version of Geo with this patch and others applied is available here:
http://hg.invisibleinstitute.com/drupal/geo_patched/

allie micka’s picture

allie micka
she/her
commented
Status: Needs review » Fixed

Committed - thanks becw!

becw’s picture

becw commented

Thank YOU, Allie!!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

zazzu’s picture

zazzu commented

the link to http://hg.invisibleinstitute.com/drupal/geo_patched/ is broken...

becw’s picture

becw commented

the patch has been committed, so my patched branch is no longer necessary :)