#348907 follow-up: inline documentation of _privatemsg_generate_user_array() [#429488]

Documentation of _privatemsg_generate_user_array() says:

  // convert user uid list (uid1,uid2,uid3) into an array and only load the last 4 uids.
  $users = array_slice(explode(',', $userstring), -4);

Could more be added to this saying why we only get the last 4 uid's? Is it arbitrary?

Good on you for documenting it at all, however! :)

Comment	File	Size	Author
#3	doc_improvement.patch	843 bytes	berdir

Comments

Comment #1

liam mcdermott commented 9 April 2009 at 23:37

Issue tags:

+348907

Comment #2

berdir

German

Switzerland

commented 10 April 2009 at 16:01

Performance reasons, we only display 4 authors per thread, we shouldn't load all others.

Imho, we should think about "fake" user objects (stdClass with username and uid) when we only want to use them for theme('username'). We could also use a query per thread row, because we could then limit it in the query (which is not possible with GROUP_CONCAT).