Drupal.org

Removed meta data for dynamically generated handbook pages - i.e. Recent changes

Project:Drupal.org infrastructure
Component:Drupal.org module
Category:task
Priority:normal
Assigned:courtney
Status:closed (fixed)
Issue tags:drupal.org redesign

Issue Summary

There are a number of handbook pages which are output via the drupalorg_handbook module. An example is the recent changes page:

http://drupal.org/node/23192

These are book node pages which have their content output via the module.

The drupalorg_handbook.module was adding the meta data to the top of these pages, but Last modified isn't relevant for dynamically generated pages. Therefore, I commented out the output of the meta data - line 54 in drupalorg_handbook.module

Comments

#1

Sounds great. It seems like this was in this commit http://drupal.org/cvs?commit=195082 ?

It would be nice if you could create the issue first (either in infrastructure or drupalorg) and then mention the issue in the commit message.

#2

Yes, the commit for this was http://drupal.org/cvs?commit=195082

Thanks for the tip, I'll create the issue first and mention it in the commit moving forward.

#3

Status:fixed» closed (fixed)

Actually, I made an assumption that the dynamic pages didn't have node content, and all do except for the recent changes page that just returns a dynamically generated table. All of the other ones do have content and therefore, the meta data applies. I'm undoing the update I made to remove the meta data since there is just one exception and this exception may have content added to the node in the future (i.e. intro paragraph describing the table). Changing to closed.