Posted by thierry_gd on January 1, 2006 at 9:58pm
| Project: | Blix |
| Version: | master |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | thierry_gd |
| Status: | closed (fixed) |
Issue Summary
After upgrading to 4.7 the search button don't work anymore when you use the Blix theme.
(sorry to fill this bug here but the category blix don't have been created in the bug tracking system).
Comments
#1
I found from where come the problem : it come from the modification in PHPtemplate in 4.7.
To make the button "search" work with blix theme in version 4.7, you have to modify the file page.tpl.php.
#2
I found from where come the problem : it come from the modification in PHPtemplate in 4.7.
To make the button "search" work with blix theme in version 4.7, you have to modify the file page.tpl.php.
Replace :
<form action="<?php print $search_url ?>" method="post" id="searchform">
<fieldset>
<input type="text" value="" name="keys" id="s" />
<input type="submit" value="Go!" id="searchbutton" />
</fieldset>
</form>
by :
<?php print $search_box ?>
I don't have any CVS access, so I hope someone will patch the 4.7 version.
Don't apply to the 4.6 version.
#3
Had forgotten to change the status !!!
#4
Not a patch.
#5
blix theme? Is this an official theme release with 4.7? If not, this shouldn't be applied.
#6
Blix theme is not in the Project drop down - so we can't reassign this to that theme.
I contacted adrian (blix maintainer http://drupal.org/project/blix ) via his "user contact" function yesterday asking to add it to the issues - no response yet.
Either way, this isn't "critical".
#7
Sorry - didn't mean to move the "version".
#8
Why should Drupal developers be responsible for whether or not someone's theme works with the core?
#9
Nevermind last comment. I thought you were asking a question like "This isn't critical?"
#10
This needs to be assigned to Blix theme, but that theme does not have an entry.
Assigning to Drupal.org maintenance - can you please create the issues entries for the "Blix" theme?
#11
Created and tested the patch
#12
Woohoo - blix theme is listed in dropdown so this can be reassigned.
I did not test the patch, but at least there is one now.
#13
Bullshit ! Bullshit ! Bullshit !!!
Replacing the Blix search form by
<?phpprint $search_box
?>
The issue is to replace
<form action="<?php print $search_url ?>" method="post" id="searchform"><fieldset>
<input type="text" value="" name="keys" id="s" />
<input type="submit" value="Go!" id="searchbutton" />
</fieldset>
</form>
by
<form action="?q=search/node" method="post" id="searchform"><fieldset>
<input type="text" value="" name="edit[search_theme_form_keys]" id="s" />
<input type="submit" value="Go!" name="op" id="searchbutton" />
<input type="hidden" name="edit[form_id]" id="edit-form_id" value="search_theme_form" />
</fieldset>
</form>
in page.tpl.php
Here was the different problems...
- action missing (<? print $serch_url; ?> doesn't work anymore)
- the field name for keywords has changed (edit[search_theme_form_keys] instead of edit[keys])
- input type="hidden" name="edit[form_id]" id="edit-form_id" value="search_theme_form" /> missing
Here is the new file page.tpl.php
#14
There 's no need to be rude, we are just human and sometimes make mistakes. Open-source need collaborative effort not agression
"Replacing the Blix search form by ... puts an ugly search form in the template !" ==> I agree with that, but the text I highlited is only a part of the correction I have planned. The css file has also to be updated for having a good rendition. I am still working on it as there is many improvment to be done on the css file as there is many problem with modules wich don't work correctly with blix themes as it is now.
I should upload a final version soon (as soon I get a little free time to validate it).
#15
#16
Someone (anonymous) closed it by mistake
#17
Update : modified a few extra stuff (style applied to all buttons not only the serach form ones, fixed some placement problem, ...)
#18
Closed ==> update to drupal 5