Closed (fixed)
Project:
Blix
Version:
master
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
1 Jan 2006 at 21:58 UTC
Updated:
3 May 2007 at 21:13 UTC
Jump to comment: Most recent file
After upgrading to 4.7 the search button don't work anymore when you use the Blix theme.
(sorry to fill this bug here but the category blix don't have been created in the bug tracking system).
| Comment | File | Size | Author |
|---|---|---|---|
| #17 | blix TG.patch | 42.62 KB | thierry_gd |
| #13 | page.tpl.php_2.txt | 2.39 KB | labinformatique |
| #11 | page.tpl.patch | 3.65 KB | thierry_gd |
Comments
Comment #1
thierry_gd commentedI found from where come the problem : it come from the modification in PHPtemplate in 4.7.
To make the button "search" work with blix theme in version 4.7, you have to modify the file page.tpl.php.
Comment #2
thierry_gd commentedI found from where come the problem : it come from the modification in PHPtemplate in 4.7.
To make the button "search" work with blix theme in version 4.7, you have to modify the file page.tpl.php.
Replace :
<form action="<?php print $search_url ?>" method="post" id="searchform">
<fieldset>
<input type="text" value="" name="keys" id="s" />
<input type="submit" value="Go!" id="searchbutton" />
</fieldset>
</form>
by :
<?php print $search_box ?>
I don't have any CVS access, so I hope someone will patch the 4.7 version.
Don't apply to the 4.6 version.
Comment #3
thierry_gd commentedHad forgotten to change the status !!!
Comment #4
dries commentedNot a patch.
Comment #5
Steve Dondley commentedblix theme? Is this an official theme release with 4.7? If not, this shouldn't be applied.
Comment #6
gregglesBlix theme is not in the Project drop down - so we can't reassign this to that theme.
I contacted adrian (blix maintainer http://drupal.org/project/blix ) via his "user contact" function yesterday asking to add it to the issues - no response yet.
Either way, this isn't "critical".
Comment #7
gregglesSorry - didn't mean to move the "version".
Comment #8
Steve Dondley commentedWhy should Drupal developers be responsible for whether or not someone's theme works with the core?
Comment #9
Steve Dondley commentedNevermind last comment. I thought you were asking a question like "This isn't critical?"
Comment #10
gregglesThis needs to be assigned to Blix theme, but that theme does not have an entry.
Assigning to Drupal.org maintenance - can you please create the issues entries for the "Blix" theme?
Comment #11
thierry_gd commentedCreated and tested the patch
Comment #12
gregglesWoohoo - blix theme is listed in dropdown so this can be reassigned.
I did not test the patch, but at least there is one now.
Comment #13
labinformatique commentedBullshit ! Bullshit ! Bullshit !!!
Replacing the Blix search form by
print $search_boxputs an ugly search form in the template !The issue is to replace
by
in page.tpl.php
Here was the different problems...
- action missing (<? print $serch_url; ?> doesn't work anymore)
- the field name for keywords has changed (edit[search_theme_form_keys] instead of edit[keys])
- input type="hidden" name="edit[form_id]" id="edit-form_id" value="search_theme_form" /> missing
Here is the new file page.tpl.php
Comment #14
thierry_gd commentedThere 's no need to be rude, we are just human and sometimes make mistakes. Open-source need collaborative effort not agression
"Replacing the Blix search form by ... puts an ugly search form in the template !" ==> I agree with that, but the text I highlited is only a part of the correction I have planned. The css file has also to be updated for having a good rendition. I am still working on it as there is many improvment to be done on the css file as there is many problem with modules wich don't work correctly with blix themes as it is now.
I should upload a final version soon (as soon I get a little free time to validate it).
Comment #15
(not verified) commentedComment #16
thierry_gd commentedSomeone (anonymous) closed it by mistake
Comment #17
thierry_gd commentedUpdate : modified a few extra stuff (style applied to all buttons not only the serach form ones, fixed some placement problem, ...)
Comment #18
thierry_gd commentedClosed ==> update to drupal 5