Posted by mandclu on April 10, 2009 at 12:03pm
| Project: | |
| Version: | 6.x-3.x-dev |
| Component: | User interface |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Issue Summary
Currently this module allows you to set whether or not to allow a content type to have posts tweeted, but if it is allowed, it always defaults to have posts tweeted.
I'd like to have some content types that would allow for tweeting but wouldn't be tweeted by default. My thought was that it could add a checkbox to the edit content type form to determine this.
Comments
#1
+1
#2
This issue was hard to find, but I knew it had to have already been requested (or done in a way I couldn't notice), my search words were per node type settings.
What we're looking for is a collapsed fieldset when editing each content type that lets an admin:
Would the maintainers accept a patch? The patcher will accept guidance!
ben, Agaric
#3
+1 as well.
#4
+1
#5
The attached patch is a stop-gap that implements a global default.
Attached patch also implements Drupal's "off by default" standard,
so that the "Announce this Post to Twitter" checkbox is unchecked unless admin enables the global default.
Per-content type patch forthcoming.
#6
The attached patch implements per-content type "post announcement" and "default format string" settings.
In addition, the patch allows admins to set "post announcement" default on create-only, update-only, or both.
This addresses the use case where posters want to post twitter announcements for every update to a node.
#7
subscribing
#8
good idea as of now those with permissions have to watch when posting content to un-check the twitter box as it is default to on. any way to turn that default off?
#9
CobraMP: Good point. I really would like to see both features :-)
#10
@CobraMP I believe you're discussing the same solution that aaron implemented in #5, a default setting to no twitter post.
Aaron, I applied your patch to standard 2.6 not dev. The problem I found is that you can no longer select what account you want to send tweets from, which was a given through function hook_twitter_accounts. Unless that's solved in dev, it's a problem for users who have more than one account. Otherwise, good stuff.
#11
This issue also applies to 3.x-dev branch.
Changed to bug:
By defaulting all twitter-able node forms to tweet by default, this module does not adhere to the Drupal standard, "Modules should not change the behavior of existing site configuration."
#12
rerolled #6 @ HEAD, though it looks like maintainers have lost interest in the issue queue. ::sigh::
#13
This patch is brilliant. This should be the default behavior and should be commited as soon as more people review it.
The patch applied well, and after a few tests i can confirm it works as expected.
I also believe these settings should be per content type, but i'm not sure of the work involved in doing this.
Thank you.
#14
The patch in #12 worked beautifully for me in Twitter 6.x-3.x-dev.
@Fidelix, after applying the patch, I found that I had an option at the global level in the Twitter settings, and also in the edit screen for each content type.
+1 for making "disabled" the default behavior.
Thanks so much for providing this!
#15
For the patch at #12
Perfect!
Adds global and per content type default settings. Many thanks.
#16
Awesome. Thanks SO much for this!
#17
Mahvelous. The patch at #12 did exactly what I needed.
Thanks for this!
#18
This patch is reviewed and tested (almost a year ago), but it's still not rolled into the module? What gives?
#19
Jeff, please, please, pretty please with a cherry on top, roll this into the next version of this module and before doing D7 work. This feature is so huge. I can't tell you how important it was to us to NOT have the posts default to be tweeted just because it was enabled for that type and aaron's patch at #12 is just perfect and has saved us a lot of headaches where we posted to twitter and didn't mean to. Thanks for the recent work on this and I'm holding off upgrading this module until it's made the default behavior...unless aaron or someone wants to roll a new patch against the new version and i'll patch again.
#20
Really not a code bug but a user interface feature request and seems pretty favored by many, so...and marking as major because it just doesn't make sense to tweet by default and have to uncheck every time!! Thanks :)
#21
As I'm a module maintainer now, I'll see about getting this into the next release.
#22
Patch #12 no longer works on beta4. ;-(
Any ideas here? Thanks!
#23
One idea would be to look at the patch, see where the changes are meant to be, make those changes manually, and re-roll the patch.
#24
I've rerolled the patch and pushed it to dev, so it should be available in the dev release shortly. Can some of the folks on this issue give it a try and let me know if it works as expected? Thanks!
#25
I'm seeing the status field missing for any form where posting is disabled by default. I'm not able to troubleshoot this right now, but it looks like this patch (or my re-roll of it) doesn't actually cover all its use cases.
#26
This must be commit a9a030d433466ae51ae7366734bcd2f24819c357 ? An setting pr. content type sounds like a good idea to me. Not a big issue though.
#27