updated module with added features and 4.7 compat.

A few notes:

• There should be permissions or a setting to disable HTML export - since many sites are printer-friendly already (using stylesheets).
• There's quite a mix of tabs and spaces for indentation, Drupal uses spaces.
• The form code you have used to create the table is not the Drupal standard way. I think upload.module has the simplest example for creating a table of form elements.
• Some of your block comments are not in the correct format (although I know little about this).
• There is better code for constructing the autocomplete results now available. I forget the exact function name, but it will be in user.module.

Then one of my biggest concerns: recipe has no dependancy on taxonomy_dhtml. Any features introduced to group the recipes in any way should be left as a generic taxonomy-based solution, most likely not built in to this module. I'd welcome any comments on my opinion though, as I could easily be wrong.

I think a Drupal lesson is in order ... When Thox gives feedback as a module maintainer, he is identifying deficiencies in the patch which must be corfrected before he commits the patch. That includes small stuff like changing tabs to spaces. It doesn't matter if those tabs existed before in recipe.module or elsewhere.

It is a pain to get a patch committed into Drupal, but these high standards help keep the code clean. If a person doesn't want to correct all the difficiencies identified by the module maintainer, thats OK. The patch will likely die as an unfinished contribution. It is rare that a module mantainer happily takes a far from finished patch like this one and cleans it up and commits it.

I encourage everyone to contribute patches and persist through the patch review process.

Let me say thanks for submitting this revision. I appreciate it though I am ignorant of drupal's conventions. I hope you're still checking this forum.

The complex mode works but if I set it to simple, nothing I enter in the forms is retained and I just end up creating a bunch of empty nodes (no title, nothing). Then if I switch back to complex, it won't retain any ingredients, forgetting previously entered ingredients. I've tried flushing the cache, deleting the whole module, dropping and reinstalling the tables, etc.

I have tried to rework brdwor's patch to incorporate (some of) thox's comments.

What I've done is:

1. Reordered the functions, so that it's easier to diff with the recipe.module from current CVS
2. Converted tabs to spaces
3. Fixed a few typos in comments:)
4. Use the same method of outputing autocomplete stuff as user.module
5. Added recipe.install file, which, although I haven't tested against postgres at least attempts to create the same DB structure...

I looked at the comment block formatting, but I don't understand thox's criticism here, so was unable to do anything about it. Ditto for the form generation (I'm kinda new to drupal, so maybe there's some big difference I'm not seeing - it all looks like it builds $form[] and returns it to me). Feel free to expand upon these points and I'll see what I can do.

I did not add an option to disable HTML export (yet) because I was focusing on getting existing functionality into shape first.

Here's the install file, since I can only attach one file per followup.

Attached version includes settings to enable/disable export to RecipeML/HTML.

Note that I've discovered that the custom yield feature doesn't work. As far as I can tell, $_POST is empty by the time theme_node_recipe is called, so it always defaults to showing for a yield of 1.

oops, didn't mean to attach that version...

The module attached by marble has errors.

Fatal error: Cannot redeclare theme_more_info() (previously declared in

'previously declared in' what? This module works for me in 4.7.2 without giving this error.

hey marble, thanks for the work on the patch. for the most part, its working really well.

i don't know if anyone else has this problem, but when you preview a recipe, everything you entered goes away, and it shows a blank node. none of the data entered is saved and creates a completely blank node.

When I either submit or preview a recipe I get the following message:

Fatal error: Cannot use string offset as an array in /var/www/furaphee/modules/filter.module on line 842

line 842 is in the form validate routine.

Thanks marble. This is working great for me.

A couple of things I noticed:

1) a recipe does not show up under "recipes" unless you have created a category vocabulary and assigned a category to the recipe. I don't think that this is a problem, but it took me awhile to figure out why new recipes weren't showing up after I added them.

2) if you assign a recipe to multiple categories, it shows up in the "recently added" area multiple times. So if you assign it to 3 different categories (ie. "vegetarian" and "side dishes" and whatever else) it shows up three times consequetively under "recently added".

3) if you have something associated with multiple categories (or single categories in multiple vocabularies), it only shows one of them in the summary.

I might take a crack at resolving some of the above as multiple categories are important for what I'm doing with the recipe module.

Thanks for all your work.

I have the same problem as andylei. I've installed on two different servers. Bummer cause I miss the module too...There are no watchdog errors, just blank nodes.

loganbear: I haven't been able to reproduce that problem here yet
hpn: Seems this module clashes with another one you have installed. I'll rename the theme_more_info function to theme_recipe_more_info.
andylei/jivyb: thanks for pointing that out. I am having a little trouble working out why it's happening, but I wrote a new module from scratch that can preview ok, so I'll add bits of recipe into it until I find out what breaks the preview...
drawk: thanks for the feedback, I'll try looking at it after I work out what's going on with the preview thing, but if you can fix it and attach a patch, that'd be great too.

everyone: I tried contacting Thox to see if this is ever likely to get applied, and didn't get a reply yet. I'll try contacting moshe, and if I can't get a reply there either, I'll probably have to release a forked version - keeping track of all the issues etc in one thread like this isn't very efficient.

I suspect that we need to hand over maintainership of this module to someone new. If you think you could be that someone, please contact me or Thox.

Problem resolved -- it dealt with several issues -- my starting to build a recipe module for 4.7 (the version I started with Drupal) without knowing there already was one in development -- my getting the cvs version of the recipe module -- my installing the new improved version.

When I rebuild my site from scratch, the problem disappeared.

Works fine for me.
I think this can be apply

A little spelling mistake with the word "quantity"

'#value' => '