The current state of product discounts is broken with a certain patch to Ubercart. This patch isn't going to be used because of the work going into price handlers. This issue is for the efforts to keep up with the changes made to Ubercart, though nothing can really be committed to uc_discount until Ubercart becomes stable again.

CommentFileSizeAuthor
#5 discount_uc_price_implementation.patch4.06 KBIsland Usurper
#4 uc_price_handlers_3.patch2.7 KBrszrama
#3 uc_price_handlers_2.patch2.96 KBIsland Usurper
#2 uc_price_handlers_1.patch3.09 KBIsland Usurper
uc_price_handlers.patch2.58 KBIsland Usurper

Comments

Island Usurper’s picture

Island Usurper commented

I suppose it's helpful to know which issue we're waiting on.

#399586: cha0s' attempt to solve the VAT display stuff

Island Usurper’s picture

Island Usurper commented
StatusFileSize
new uc_price_handlers_1.patch3.09 KB

First iteration.

Island Usurper’s picture

Island Usurper commented
StatusFileSize
new uc_price_handlers_2.patch2.96 KB

Second iteration.

rszrama’s picture

rszrama commented
Status: Postponed » Needs review
StatusFileSize
new uc_price_handlers_3.patch2.7 KB

Updated against the latest CVS.

Island Usurper’s picture

Island Usurper commented
StatusFileSize
new discount_uc_price_implementation.patch4.06 KB

Changing other uses of uc_currency_format() to uc_price().

Island Usurper’s picture

Island Usurper commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.