Unsure whether I'd open a dozened issues or one summary. Unfortunately enhancements and fixes for some issues overlap in one hunk, so cherrypicking cannot be blindly done using a hunk by hunk approach.

Details see http://www.lotterer.net/blog/en/165-drupal-search_filesmodule-118thl1
Patch see http://www.lotterer.net/thomas/drupal/search_files.module-1.18-1.18.thl....

Changes between Drupal search_files 1.18 and 1.18.thl.1

* feature
added dashboard as default local task to search_files menu to allow some status insight (ugly but useful)
Hunks at original line 16 and 557

* cleanup
manually deleting a directory clears associated data from search_dataset, search_files_files, search_files_directories tables in a single SQL statement. Create and leverage function search_files_delete_content_by_directory_fullpath() to complement similar new but automatically called function search_files_delete_content_by_file_fullpath();
Hunk at original line 178

* feature
detect PHP safe_mode, display status in dashboard and skip over shell_exec() which would fail anyway.
At the end of hunk at original line 178 and in hung at original line 584

* feature
do not confuse users with trailing slash issues.
Hunks at original line 228 and 314

* feature
print current working directory and turn relative pathes into absolute pathes
Hunks at original line 228 and 314

* typo
funciton -> function
At the end of hunk at original line 557

* feature
turn hardcoded “Directory Rescan Age” into a configurable parameter
Hunk at original line 568 and start of hunk at original line 584

* bugfix
configuration of “Search Label” must use #default_value not #value
Hunk at original line 568

* bugfix
there is a functional gap where vanished files were not handled at all. Regularly compare database to filesystem and remove vanished files from database.
Hunk at original line 584

* bugfix
while indexing files, skip over files which vanished before being indexed. Otherwise helper applications will get passed a nonexistent file name and fail.
Hunk at original line 640

* cleanup
remove debugging
Hunk at original line 715

* bugfix
while preparing search results, skip over files which vanished after being indexed. Otherwise functions like filectime() will get passed a nonexistent file name and fail.
Hunk at original line 812

Comments

pedrofaria’s picture

Project: Search Uploaded Files » Search Files
Version: 6.x-1.x-dev » 6.x-2.x-dev
jrglasgow’s picture

Version: 6.x-2.x-dev » 6.x-1.6

it looks like your patch is against the 1.x version

jrglasgow’s picture

thl,
I have not had much time lately to work on Search Files. Lee20 has been working on the 2.x version of the module. If you have time to work on the module I invite you to become co-maintainer of the module. To do so though you will need to apply for CVS access. Mention this comment in your application to help you get approval.

- jrglasgow

thl’s picture

jrglasgow,
thanks for the invitation. I applied and CVS commit access has been granted.

In the meantime I understood that there are two versions of search_files in the repository. My patch is against the 1.x version on HEAD, the 2.x version is on branch DRUPAL-6--2.

I need advice how development takes place here. My experience with repositories like this is to develop on HEAD and maintain (old) stuff on a branch. Do the Drupal developers follow an inverse approach? Or is the branch used temporarily just to not affect the stable (?) 1.x version while hacking wild towards 2.x? Is the 1.x maintained at all?

Please tell me. Or point me to a documentation so I get the big picture. I also need to know how to trigger rolling and publishing a tarball or is this a manual task? The naming/numbering of branches, tags and tarballs including alpha/beta is also important to know.

thl’s picture

Assigned: Unassigned » thl
Status: Active » Fixed

I split up all issues into discrete patches and committed them as search_files.module version 1.21 to 1.31

1.21
Fixed typo.

1.22
Fixed configuration of "Search Label" must use #default_value not #value.

1.23
Fixed superfluous debugging output.

1.24
Added code to clear associated data from search_dataset, search_files_files and search_files_directories tables when manually deleting a directory. Create and leverage function search_files_delete_content_by_directory_fullpath().

1.25
Fixed functional gap where vanished files were not handled at all. Regularly compare database to filesystem and remove vanished files from database. Create and leverage function search_files_delete_content_by_file_fullpath().

1.26
Fixed issue with files vanished before being indexed. Skip over them, otherwise helper applications will get passed a nonexistent file name and fail.

1.27
Fixed issue with files vanished after being indexed. Skip over them, otherwise otherwise functions like filectime() will get passed a nonexistent file name and fail.

1.28
Added support for relative pathes. Changed handling of trailing slash to be more user friendly.

1.29
Changed hardcoded "Directory Rescan Age" into a configurable parameter

1.30
Added detection for PHP safe_mode and skip over shell_exec() which would fail anyway.

1.31
Added dashboard as default local task to search_files menu to allow some status insight.

Next item on my agenda is to merge fixes and enhancements into 6.x-2.x branch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.