Posted by fago on April 10, 2009 at 8:11pm
8 followers
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | menu system |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Issue Summary
In the rules admin ui I have the path "admin/rules/rules/%" as well as others below that like "admin/rules/rules/%/delete" or "admin/rules/rules/%/edit/%". The problem is now that the paths "below" doesn't get the parent correctly assigned. So they loose the overall context, meaning even the administration menu point is closed - what is weird.
The problem is that "admin/rules/rules/%" gets hidden set to -1 and as a consequence the parent is set to 0 and the context is gone. Is there a cause for doing so?
I tried removing this behavior, which fixed the problem for me and i didn't note any other issues with it. Patch attached.
Note: I had the problem in d6, but I think it applies to d7 as well. The patch is for d6, but applies to d7 too.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| menu_parents_fix.patch | 846 bytes | Idle | Failed: 10684 passes, 1 fail, 0 exceptions | View details | Re-test |
Comments
#1
fixing title
#2
#3
Does the issue apply all times the parent menu contains %?
#4
The last submitted patch failed testing.
#5
ok, it's not so simple.. ;) Menu items appearing in the tree may not have callbacks as parents, as then wouldn't be displayed any more. I've updated the patch, so it allows just callbacks to have other callbacks as parents.
Updated patch for d7 attached, applies to d6 too (and fixes my problem there).
#6
#7
Nice catch. These are the hardest to find, these half line fixes...
#8
please re-roll w/ diff -up, can't readily tell what function this is affecting.
Also, I think I understand the problem, but a little further explanation would help.
Also code comment is > 80 chars.
#9
Three things:
1. This sounds like a big edge case we're likely to break again without a test. So let's add one.
2. Unless mine eyes deceive me, that comment is wider than 80 chars.
3. The comment could also use some work. While I'm sure it's technically accurate, it doesn't tell me "why."
#10
Spelling correction in issue title.