Posted by quicksketch on April 11, 2009 at 5:13am
2 followers
Jump to:
| Project: | Fivestar |
| Version: | 6.x-1.13 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | quicksketch |
| Status: | closed (fixed) |
Issue Summary
This problem specifically affects widgets that have not yet been voted on. When the widget is empty, the description text is blank and the description is given a class of "fivestar-summary-". This should be populated with "No votes yet." and have a class that matches the configuration settings for that node type.
This problem seems to be caused by using NULL as the default value for votes if they're not found. When theme_fivestar_summary() is called, it specifically differentiates between NULL and a 0 value. However if we're passing in a value of NULL when a node hasn't received any votes, this results in all the parameters being NULL and no text is generated at all. We should pass in 0 when a user hasn't voted.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| fivestar_empty_text5.patch | 1.47 KB | Ignored: Check issue status. | None | None |
| fivestar_empty_text6.patch | 2.19 KB | Ignored: Check issue status. | None | None |
Comments
#1
Committed. Please reopen if any problems were caused directly by this patch.
#2
Oops a dvm and some other patches slipped into this. Removed.
#3
Automatically closed -- issue fixed for 2 weeks with no activity.