Closed (fixed)
Project:
Drupal.org Redesign
Component:
Documentation
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
11 Apr 2009 at 21:35 UTC
Updated:
3 Jan 2014 at 00:07 UTC
Jump to comment: Most recent
Comments
Comment #1
gábor hojtsyI already covered this in #429410: Page titles when viewing pages with a content menu - i.e. Modules page:
"Note that some pages will be tricky and will need handbook reorganization for example. Such as the mailing list page. It has a tab in the navigation on its own, but it is also currently a handbook page. So by general rules, the handbook tabs and title should appear, but it has its own tab and title. We could make exceptions in code, but I'd rather have the handbook clearly organized to avoid such cases."
I am not sure that having one-per-one special casing for these nodes is a good idea. We have such ugly code enough. I believe the handbook just should not have pages wildly included from around the site. The handbook can always reference those pages.
Comment #2
courtney commentedWhat type of change do you suggest in the handbook organization to fix this particular issue? As long as the page is a 'book' type node, then per the crosssite module, the Documentation section menu will become active (line 351 in drupalorg_crosssite.module). Should the Mailing list and other pages linked as tabs outside of the documentation section be 'page' type nodes?
Comment #3
gábor hojtsyChanging types does not solve any of our problems. That code in crosssite module should check for book navigation placement (!empty($node->book['bid'])), which is completely node-type agnostic and is filled in for every node which is somehow in a book. I think we need a documentation change. We need to explain this to the documentation team:
Due to the hopefully clearly explained reasons, I believe our only way to solve this is to break out from this "can show up in multiple sections" state.
Comment #4
gábor hojtsyMoving it to the documentation team. Please read the above explanation. We need a list of docs pages which are in this conflict, so that the docs team can work this out.
Comment #5
add1sun commentedI don't think this is a doc team issue. This is a webmaster issue as far as I can tell since it is about higher level, moving stuff around for the redesign. That is, I don't see what the doc team needs to "work out" but I do see that webmasters need to sort some things out.
I'm not clear what is required. I'm assuming that, since all book pages must be part of a book, that you will need to copy the contents into a page content type instead, or make each existing page its own "book"? Either way is fine to me, though I think making them pages makes things cleaner, though that would require a redirect for the node IDs. The Drupal project page (http://drupal.org/project/drupal) isn't part of any book right now, so I'm not sure what we need to do to it.
A more detailed list of the pages that need to move, as well exactly what info in them is needed (i.e. is the entire IRC page content needed or just a subset of it?), and what we need to do to them to "move" them would be great.
Comment #6
gábor hojtsyHm, well, I believe the core project was part of a book previously. Anyway, keeping existing node IDs and just migrating the node type from book to page is certainly possible since we are looking at tasks involving writing update functions, munging the DB and so no. The more such changes we do before the redesign deployment however on the live site, the better, so the possible problem areas are kept in control.
Comment #7
add1sun commentedAh, agreed. If we can just move the node type (and check for book outline stuff), that would be ideal.
Comment #8
vm commentedThis reads like something for redesign to look at ?
Comment #9
lisarex commentedLinking this from the Redesign project #661566: Meta issue for Drupal.org webmaster project because this issue was tagged 'drupal.org redesign'
Comment #10
todd nienkerk commentedI'm removing the Blue Cheese tag, as this isn't really a theme-related issue.
Comment #11
todd nienkerk commentedComment #12
todd nienkerk commentedComment #13
drummSeems to have been done at some point.