...because if the $order->uid == 0, it'll pull the global $user. It shouldn't do that here.

CommentFileSizeAuthor
#3 431140.ca_user_name.2.x.patch864 bytescha0s
#1 431140.ca_user_name.2.x.patch694 bytescha0s
ca_user_name.04-10-09-17-23.2.x.patch687 bytescha0s

Comments

cha0s’s picture

cha0s commented
StatusFileSize
new 431140.ca_user_name.2.x.patch694 bytes

Er, the return might help ;P

rszrama’s picture

rszrama commented

Hmm... what if the order has a uid but the user was deleted? I don't suppose that would really matter... it would still generate a FALSE, right?

cha0s’s picture

cha0s commented
StatusFileSize
new 431140.ca_user_name.2.x.patch864 bytes

It should be fixed, 'cuz if uc_order_load returns FALSE, it'll throw a warning about trying to access the property of a non-object. I decided to be extra explicit and add the return FALSE, too.

rszrama’s picture

rszrama commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.