"Force Private" setting does not work for the attachment module
dmuth - January 3, 2006 - 05:34
| Project: | Attachment |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | won't fix |
Jump to:
Description
I discovered that the force_private setting does not work for version 4.6.0 of the attachment module. I guess the best way to fix this would be to supply a patch for the filemanager module.
-- Doug
| Attachment | Size |
|---|---|
| attachment.diff.txt | 853 bytes |
#1
doug, i'm not quite sure what the patch you attached is supposed to do... could you clarify it's purpose?
#2
Sure. I went into /admin/settings/filemanager on my machine, and went all the way down to the bottom. I have a line item for "Attachments", and I checked the "Force Private" checkbox. If I understand Filemanager correctly, this means that files attached to nodes, when uploaded, should be served through the filemanager module.
However, what happened instead is that the attachment module didn't "know" about this setting, and would make the file publically available instead. The patch that I wrote causes the attachment module to properly set the file as private.
I wasn't sure whether to file this here, or with the attachment module. But I figured that if similar patches for other modules end up happening in the future, it would be easier to store them all with the file manager module, then store them all in seperate modules. I'm open to suggestions, though!
-- Doug
#3
Moving this to the attachment module as it's not a bug with the filemanager module itself. I will look into updating the filemanager documentation.
#4
This should be unnecessary as the filemanager code automatically forces this for you. In addition the latest filemanager code will allow forcing private by area.