It would be more convenient if includes would be included through hook_init(), and user doesn't need to manually enable module.

I've set it to Needs review, however someone with CVS permissions needs to:
1) Delete the info files or rules and services.
2) Rename userpoints_rules.module >> userpoints.rules.inc -- note the dot (.) between the modules name.

CommentFileSizeAuthor
user_points_include_files.patch777 bytesamitaibu

Comments

jredding’s picture

jredding commented

I like this approach because I don't think we need to whittle down core to just a single module to enabled. I like the hook_init approach

Can you point to some other modules that take this approach? I'd like see if there is some precedence on how best to handle this in Drupal.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

nodequeue for example.

jredding’s picture

jredding commented

hhmm.. ok.

What about branching out the tiny bit of views code to the .inc too? (can we do that)

kbahey?

kbahey’s picture

kbahey commented
Status: Needs review » Needs work

I agree with this approach.

We reduce the number of .modules that we include, clutter in the user interface at admin/build/modules, and manual steps required.

Go ahead and do the views part as well.

manuel.adan’s picture

manuel.adan
Location 🌌
commented
Component: Code: userpoints API » Code: userpoints
Assigned: amitaibu » Unassigned
Issue summary: View changes
Status: Needs work » Closed (outdated)

Closing this as outdated, 6.x version is no longer maintained.