Download & Extend

Add theme function for avatar selection (so that imagecache can be used)

Project:Avatar Selection
Version:6.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

All the avatars are different sizes how do i scale it so all of them stay one size?

Comments

#1

Category:support request» feature request
Status:active» closed (won't fix)

There's no support for imagecache at present, and I don't really plan on adding this feature unless more people request it, sorry.

Cheers,
Stella

#2

consider this a request, it would help streamline

#3

request.

#4

I'd love to see imagecache integrated into this module, so I'm adding my voice to the list of requesters.

In fact, there's a module called ImageCache Profiles that already works really nicely, and if this module could work in tandem with it, it would make this module really powerful.

#5

request too please :D
thanks

#6

I'd like to clarify that imagecache works great with this module, in terms of scaling the user's profile picture once they have chosen one (in comments, posts, their profile page, etc). However, allowing it to work its magic on the selection list would be a great additional feature. So add my name to the list of requests, and thanks for your great work on this module!

#7

Title:How do i scale all avatars through imagecache?» Add theme function for avatar selection (so that imagecache can be used)
Status:closed (won't fix)» active

I can understand you not wanting to add full imagecache integration. However, it would be nice to at least have a theme function which allows the images to be resized and formated as needed.

#8

Request!

#9

Request :)

#10

Version:6.x-1.5» 6.x-1.x-dev
Status:active» needs review

Great module Stella! I wanted imagecache support for my own project, so I've added it :)

Here's my patch - please could you test and review. This is my first time submitting a patch to Drupal so please let me know if I've done anything incorrectly.

Thanks

AttachmentSize
avatar_selection-imagecache-431500.patch 2.78 KB

#11

I tried the patch and it works fine, thank you. One thing I noticed is that the image is missing the width and height attributes, affecting page speed. Should that be reported as a separate issue?

#12

Status:needs review» fixed

Committed, thanks!

#13

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#14

that patch is leaving a *.orig file when applied. Trying a git patch version to see if differs when used with our apci.make.

AttachmentSize
avatar_selection-imagecache-431500-14.patch 2.51 KB

#15

or you can just use the dev version since it was committed already

nobody click here