Stop using post as a noun

Hell yes. Subscribe.

Me too. I intend on working on this, but if somebody beats me to it, that's fine also.

subscribe

subscribe

Grepped up a list of occurances, will start knocking them off.

Here is the initial list of usages (without any changes). I did not include function names or code comments.

Some interesting cases I have found:

For the numerous lines such as:
"The comment module allows visitors to comment on your posts"
"comment on content" sounds odd to me, although no one on irc had a problem with it. I will use "comment on %type" where I can, but many of these are not in the context of a specific content type.

"Returns a list of the most recent posts in the system."
Again, "recent content" doesn't seem right, or accurate in this case. The specific quote came from the blog api, where it can be replaced by "recent blog entries", but the "recent posts" phrase is also used in aggregator and suchlike, where it can apply to comments as well.
In short, "content" doesn't imply comments. What word should replace "posts" in that context?

There is also one permission that applied: "view post access counter".

That is just a preliminary list, I have not started changing them yet; I will make a start on that.

Here is the start of the patch. It does not contain all of the instances and I did not test it yet.

In the book module, I added the actual content type in place of "post". However, I am not sure if I am doing it right:

drupal_set_message(t('The post has been added to the selected book. You may now position it relative to other pages.'));

to

drupal_set_message(t('The !post has been added to the selected book. You may now position it relative to other pages.', array('!post' => $node->type)));

I am emulating what I saw another module do in a similar situation. Should "!" be used on the node type, or should it still be passed through check_plain with % or @. Is showing the machine name acceptable, or should it pull the human name for the type?

There is a strange line in the schema for comment module:

'description' => 'Maintains statistics of node and comments posts to show "new" and "updated" flags.',

"comments posts" looks like a mistype to me. Would changing this break something? Is an updater needed for changing the description?

Forums use "post" to describe user comments by convention, and "content" would probably just add confusion to it. What say you?

I will review this later on, can you supply the instances where you did not change it yet?

Some time ago I lost all the work I did on this, and forgot to say so. I apologize, I am not working on this anymore. If no one else picks it up before then, I might take it up again (time permitting).

Bah, I had this issue locked for too long and prevented more work, so its only fair that I complete what I took up. I will put this as my first priority and grind it out asap.

That took a lot less time than I was taking before...

I did not change any permissions, and left most of the "post" mentions in the forum module, as that is the most often used word among other forums.
Some comments were updated.
I reworded a few output sentances on the lines I was working with as well. Not all rewordings were nessescary for the change, but it makes them more readable.

Something to check: a few added uses of "content" may not make sense in translation.

Menu link titles and one menu path was changed in the tracker, and the tests were updated to reflect this.

Forgot -p

I tried to apply the patch in #20 against D7 and failed. I tried -p0 and -p1. 1 was required to find the files and gave me a whole bunch of fresh new *.rej files to share. :-)

I'm guessing core has changed a lot since Sept. For example, this patch includes string changes for the upload module.

This would've been nice to do, but I'd prefer not to make anymore non-critical string clean-ups in Drupal 7 anymore, to help ease translations.

I love this, and I hope it gets in early once development on 8.x opens. :) So, to help this along, here's a quick review of the latest patch:

- * a forum topic, weblog post, story, collaborative book page, etc.
+ * a forum topic, weblog entries, story, collaborative book page, etc.

As it's singular, it should probably just be "weblog entry".

Your site content can be created in (and translated to) any enabled language, and every content may have a language-appropriate alias for each of its translations.

Probably "every piece of content".

+ drupal_set_message(format_plural($update_count, 'Changed the type of 1 content from %old-type to %type.', 'Changed the types of @count content from %old-type to %type.', array('%old-type' => $info->old_type, '%type' => $info->type)));

+ drupal_set_message(format_plural($update_count, 'Changed the type of 1 content from %old-type to %type.', 'Changed the types of @count content from %old-type to %type.', array('%old-type' => $info->old_type, '%type' => $info->type)));

Again, "piece of" and "pieces of" content.

+ $caption .= '<p>' . format_plural($num_nodes, '<strong>Warning:</strong> there is currently 1 %type content on your site. It may not be able to be displayed or edited correctly once you have removed this content type.', '<strong>Warning:</strong> there are currently @count %type content on your site. They may not be able to be displayed or edited correctly once you have removed this content type.', array('%type' => $type->name)) . '</p>';

"X piece(s) of %type content"?

+    watchdog('content', 'Deleted @count contents.', array('@count' => $count));
+    drupal_set_message(t('Deleted @count contents.', array('@count' => $count)));

"Content" can't be counted (grammatically, anyway), so we need "pieces of content" in both places.

+ $output = '<p>' . t('The node module manages content on your site, and stores all content (regardless of type) as a "node" . In addition to basic publishing settings, including whether the content has been published, promoted to the site front page, or should remain present (or sticky) at the top of lists, the node module also records basic information about the authors of the content. Optional revision control over edits is available. For additional functionality, the node module is often extended by other modules.') . '</p>';

stores all content (...) as a "node" . -> "stores all content (...) as "nodes"."

+ $output .= '<p>' . t('Though each content on your site is a node, each content is also of a particular <a href="@content-type">content type</a>. <a href="@content-type">Content types</a> are used to define the characteristics of content, including the title and description of the fields displayed on its add and edit pages. Each content type may have different default settings for <em>Publishing options</em> and other workflow controls. By default, the two content types in a standard Drupal installation are <em>Page</em> and <em>Story</em>. Use the <a href="@content-type">content types page</a> to add new or edit existing content types. Additional content types also become available as you enable additional core, contributed and custom modules.', array('@content-type' => url('admin/structure/types'))) . '</p>';

Though each content on your site is a node, each content is also of a particular content type. -> "Though all content on your site are nodes, each piece of content is also of a particular content type."

+ return '<p>' . t('The revisions let you track differences between multiple versions of content.') . '</p>';

Is the mentioning (ie., its placement on a site) of this in general or related to a/one "post"/piece of content? If it's "in general", the wording is OK, if it is in relation to a piece of content, it should rather be just that "of a piece of content."

+ $output .= '<p>' . t("The <em>Recent content</em> page is available via a link in the navigation menu block and displays new and recently-updated content (including the content type, the title, the author's name, number of comments, and time of last update) in reverse chronological order. Posts are marked updated when changes occur in the text, or when new comments are added. To use the tracker module to follow a specific user's contributions, select the <em>Track</em> tab from the user's profile page.") . '</p>';

Posts are marked updated [...] -> "Content is marked updated [...]"

+ drupal_set_message(t("You have added an action that changes a content's property. A Save content action has been added so that the property change will be saved."));

that changes a content's property. -> "that changes a piece of content's property." or "that changes the property of a piece of content." ("Content" can't be counted, so you can't have "a/one content".)

Powered by Dreditor.

Dropping this for now, I cannot run D7 until I work out some PDO issues with my host.

Actually this seems to introduce a lot of entries of the word 'node' we removed this word from core, because of its technical nature. Other than that most changes seem good.

Made this apply to D8. Marking as NR for testbot, but I'm sure this will still need a lot of work.

Fixed the $t typo.

#40: stop_using_post_as_noun-431612-40.patch queued for re-testing.

-1

maybe irrelevant at this point, but after reading [#1818278: Rename "node" to "content"] I actually think "post" is a reasonable term to use as a noun and it seems most people, whether intentional or not, seem to use it this way quite commonly.

Based on the outcome of https://www.drupal.org/node/1818278, I think we should rename "post" to "node" in user-facing text to create a consistent terminology. I don't love "node" but if we're going to use "nodes" instead of "content" then we should also use "node" instead of "post".

Looks all issues like #1818278: Rename "node" to "content" closed and we are behind a string freeze
No where we going to finish node to content transition?

No matter what, this is 8.1.x.

This may be outdated and needs a check to see if there are still problems in D11 code. Please scan the code for uses of "post" as a noun, but ignore test fixtures.

Then spin off child issues by sub-system to keep the patches/MRs reasonably-sized.

From @andypost at https://drupal.slack.com/archives/C014QES6HSQ/p1696523077987389?thread_t...

In UI as noun it exists in forum...

core/modules/forum/src/ForumSettingsForm.php:54: 3 => $this->t('Posts - most active first'),
core/modules/forum/src/ForumSettingsForm.php:55: 4 => $this->t('Posts - least active first'),
core/modules/forum/templates/forum-list.html.twig:40:

{{ 'Posts'|t }}

I searched core for POST and visually scanned the long list to confirm the usages were for the POST method. Then I searched for 'Post' and did the same scan. Finally searched for 'post' and there were many results. I gradually eliminated correct usages such as 'post update' etc. and eventually the results were small enough to change the grep to include the cases where post is used as a noun. This is the resulting command.

grep -rw post --exclude-dir=fixtures core/modules/book core/modules/forum core/modules/tracker core/includes/form.inc | grep -v 'post comments' | nl

The three modules, book, form and tracker, are approved for removal so we can eliminate those. That leaves form.inc which has an example using post as a noun.

 *   if ($success) {
 *     $message = \Drupal::translation()->formatPlural(count($results), 'One post processed.', '@count posts processed.');
 *   }
 *   else {

There is a change for that in the latest patch here. So we just need a new MR with that one change.

I have updated the IS and added some, but not all, credit.

After reading the relevant code, "items" makes sense in context and !4956 looks good.

Thanks, @sourabhjain.

Saving credit

Nice to close a 15 year old issue!

Committed to 10.2.x and 11.x Thanks!