Download & Extend
DiggBar Blocker » Issues

Duplicate functionality?

Posted by mcrittenden on April 13, 2009 at 2:48am
Project:DiggBar Blocker
Version:6.x-1.0-beta1
Component:Miscellaneous
Category:task
Priority:minor
Assigned:henrrrik
Status:needs review

Issue Summary

This module may be seen as a duplicate of http://drupal.org/project/diggbar although this module seems to redirect the user to the actual URL and that module displays a message. Might be good to combine forces and have one module which gives the option to do both/either. Just a suggestion :).

Login or register to post comments

Comments

#1

Posted by henrrrik on April 13, 2009 at 12:07pm
Assigned to:Anonymous» henrrrik

diggbar_blocker.module currently has a couple of advantages.

  1. Removes the DiggBar
  2. Redirects to the original URL or a special page
  3. Since it's JavaScript it works with any level of caching, including Boost module or a reverse proxy cache (which might be useful if you're dugg)

#2

Posted by mcrittenden on April 13, 2009 at 2:21pm

Hmm, I missed the part about redirecting the user to a specified URL. That pretty much replaces the need for a special message ala /project/diggbar, so never mind :).

#3

Posted by mannkind on April 14, 2009 at 11:23pm

EDIT: Lame, it didn't save my comment!

In the spirit of collaboration and consolidation, I submit a patch (against CVS) to you sir!

AttachmentSize
diggbar_blocker-431902.patch 3.87 KB

#4

Posted by mannkind on April 14, 2009 at 11:23pm
Status:active» needs review

#5

Posted by mcrittenden on April 15, 2009 at 12:30am

Mannkind, awesome. If I could send you a cookie right now, I totally would. Hopefully henrrrick will pick it up and get the best of both worlds :).

#6

Posted by Dave Reid on April 16, 2009 at 4:40am

This module should actually be marked as a duplicate of the *original* one, Frameprevention.

#7

Posted by henrrrik on April 16, 2009 at 1:18pm

The main difference is that this module only targets digg.com as referrer (+ the redirect functionality). It's more of a temporary campaign module against the DiggBar and with the latest developments it seems it might not be necessary for much longer.

@mannkind: Cheers for the patch, though I don't think either of us needs to spend more time on this.