Closed (fixed)
Project:
Flag Form
Version:
6.x-1.x-dev
Component:
Miscellaneous
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
13 Apr 2009 at 06:04 UTC
Updated:
27 Apr 2009 at 13:30 UTC
Marking #353534: Add Checkboxes as Display Type as a duplicate of this module. I have yet to review the module, but tentatively, it looks beautiful.
Out of curiosity, what itch motivated you to write this?
Comments
Comment #1
aaron commentedThanks!
The module is still in its early stages: further plans include having the form use AHAH to submit inline rather than with a new page load; then add submit handlers on checkboxes so you can have immediate feedback. Also, I think (but haven't yet confirmed) there's a minor PHP error on node submission a well. Finally, I currently have the link displayed in the $node->content array rather than as a link, and I'm not sure that's best. Oh, and it won't work with Views yet either.
Having said that, I think the module is sound for the specific edge case of displaying flags with checkboxes, and separating that out allows Flag module development to continue unhindered.
This functionality was needed by a client, and I didn't see the linked issue after an initial scan. I'm sort of glad I didn't, because after reading it, I may have been influenced to go down a rabbit hole of development, rather than (for me) the simpler route of using form & link alters to achieve the required results. The Flag module has a fairly sound API (although I did find a couple of areas that could use refinement, such as the glaring lack of hook_flag_alter).
Aaron