The admin screen do not use format_interval() to display the autocommit interval, which result in uglyness when anything that is not a multiple of a minute is used for this value.

CommentFileSizeAuthor
#6 432140-format-interval-autocommit.patch4.41 KBdamien tournoud
#5 432140-format-interval-autocommit.patch3.96 KBdamien tournoud
#4 432140-format-interval-autocommit.patch3.96 KBdamien tournoud
#3 432140-format-interval-autocommit.patch3.97 KBdamien tournoud
#1 432140-format-interval-autocommit.patch2.28 KBdamien tournoud

Comments

damien tournoud’s picture

damien tournoud commented
Status: Active » Needs review
StatusFileSize
new 432140-format-interval-autocommit.patch2.28 KB
pwolanin’s picture

pwolanin commented

looks good, but I think perhaps there is another message that uses the value too?

damien tournoud’s picture

damien tournoud commented
StatusFileSize
new 432140-format-interval-autocommit.patch3.97 KB

Yes. Here is a full version.

damien tournoud’s picture

damien tournoud commented
StatusFileSize
new 432140-format-interval-autocommit.patch3.96 KB

Oups.

damien tournoud’s picture

damien tournoud commented
StatusFileSize
new 432140-format-interval-autocommit.patch3.96 KB

Ok, last version, tested.

damien tournoud’s picture

damien tournoud commented
StatusFileSize
new 432140-format-interval-autocommit.patch4.41 KB

And changing the defaults too.

pwolanin’s picture

pwolanin commented
Status: Needs review » Fixed

committed to 6.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.