I feel there is a bug in the js if you chage the previous & next link with images

junedkazi - April 13, 2009 - 13:37
Project:Slideshow
Version:6.x-2.1
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:active
Description

Hi,

Here is what I did,

I tried to replace the previous & next text links with images using a theme override at the
template level using the following function in template.php

<?php
themename_slideshow
()
?>

Now when I refresh the page and when I click the previous & next image
The previous & next image also gets replaced by the current image
due to the following line in the js.

.find('img').attr('src', current.src).end()

so all the image source for the slideshow are changed with the current slideshow image

So to avoid it I would suggest we could use

.find('.image').attr('src', current.src).end()
as this is the id used with the slideshow images.

Also I would suggest to use some better class in place of "image" like "slideshow-images" or something better.

#1

junedkazi - April 13, 2009 - 13:37
Title:I feel there is a bug in the js» I feel there is a bug in the js id you chage the previous & next link with images

#2

junedkazi - April 13, 2009 - 13:38
Title:I feel there is a bug in the js id you chage the previous & next link with images» I feel there is a bug in the js if you chage the previous & next link with images
 
 

Drupal is a registered trademark of Dries Buytaert.