Admin pages

agentrickard - April 13, 2009 - 20:43
Project:Dashboard
Version:HEAD
Component:User interface
Category:task
Priority:critical
Assigned:agentrickard
Status:needs work
Issue tags:drupal.org redesign
Description

Here is a patch that separates the admin pages for the various dashboards.

I think this is RTBC, but would like some feedback. The concept is that the second-level menu items (like /admin/settings/dashboard/default/block) will be used to limit the available widgets, whereas the main screen is a global on/off for widget types.

Note also the concepts of restricting the amount of content on a Dashboard -- this is crucial for performance.

AttachmentSize
dashboard-admin.patch5.97 KB

#1

agentrickard - April 13, 2009 - 21:01

Revised patch catches an error and splits hook_dashboard_widget() into an _info() hook and a data hook.

AttachmentSize
432700-admin.patch 6.07 KB

#2

agentrickard - April 13, 2009 - 21:02
Status:active» needs review

#3

christefano - April 13, 2009 - 22:02

This is the same as above but makes makes the case of "Dashboard" consistent. It's a minor change but it beats saying "subscribe."

AttachmentSize
432700_dashboard-admin.patch 5.97 KB

#4

christefano - April 14, 2009 - 03:11

Sorry, use this one. #3 was accidentally based on the original patch instead of #2.

AttachmentSize
432700-admin.patch 6.07 KB

#5

agentrickard - April 14, 2009 - 16:15

OK, I am ready to commit this patch, which includes a much larger change that separates Dashboard definitions and Widget definitions into separate include files and directories, Views and CCK style.

This will break things for a bit, but I think we need to bull forward.

Dashboard definitions now live in module_dir/dashboards/name.inc and Widgets live in module_dir/widgets/name.inc.

Tested the new logic by moving the drupalnews widget into drupalnews/widgets/news.inc and changing drupalnews_dashboard_widget() to drupalnews_dashboard_widget_info().

Note also that individual admin settings pages for widgets are now optional, if you set $widget['settings'] => FALSE in your _info hook.

Having trouble with a patch file, so attaching the whole folder.

AttachmentSize
dashboard.zip 17.31 KB

#6

ceardach - July 3, 2009 - 04:07

tagging related issues

#7

drumm - August 26, 2009 - 07:51
Priority:normal» critical

I've been doing some housekeeping on this module. This looks like it will be the next thing to review sometime tomorrow. An updated patch would be great.

#8

drumm - September 1, 2009 - 08:15
Status:needs review» needs work

It looks like a lot of this, like the widget includes, is duplicating what we want ctools content types to do.

 
 

Drupal is a registered trademark of Dries Buytaert.