using on D6.9, all works great on local test server and online site. Although, when I uninstall the module, it ALSO deletes all my menu items. Tested other modules, no others do this so far. Also tested with using only core modules, and taxonomy breadcrumb, still happens. Use basic settings, "include" and specified content type story. HELP! Thanks...

CommentFileSizeAuthor
#3 433020_menu_fix.diff1.57 KBMGN

Comments

dinknaround’s picture

dinknaround commented

BUMP? BUMP? Anyone? ... So far I think this is due to the hook_menu function with the item taxonomy/term/%. Even though this module does NOT set menu items, deleting this module will delete menu items with the path of taxonomy/term/% because of the hook used. Anyone with idea how to fix this?

MGN’s picture

MGN commented

Thanks for the extra info. When you say "deletes all my menu items" do you really mean all or do you mean items with path taxonomy/term/%?

I am preparing a patch I would like you try to see if it addresses the issue...should be able to post it soon.

MGN’s picture

MGN commented
StatusFileSize
new 433020_menu_fix.diff1.57 KB

Here is the patch. Its just a cleaned up version of one of the patches from #395082: Confilct with Taxonomy Manager. Call to undefined function taxonomy_term_page(). It replaces the hook_menu item with a hook_menu_alter call. I've tested it and from what I have seen, taxonomy_breadcrumb still works as expected. Let me know if this fixes the problem for you.

MGN’s picture

MGN commented
Status: Active » Postponed (maintainer needs more info)
dinknaround’s picture

dinknaround commented

Thanks a million MGN! "All my menu items" -- i did mean taxonomy/term/% ones only, sorry! I just spent today digging deep and was just about to hack this module and try out the hook_menu_alter function to see if that would fix it (then post result if successful). You beat me to it! I will re-install module, apply your patch, and let you know if it works...fingers crossed!

Thanks again!

dinknaround’s picture

dinknaround commented

Hey MGN...yes, awesome, that works! I also tried with changing $callbacks to $items; as discussed at http://drupal.org/node/357429. Although, brain must be foggy since I'm confused about their final decision...to use $callbacks or $items. Either way, for now they both work on a D6.9.

BTW...apologies for not catching post & comments about Taxonomy Breadcrumb and Taxonomy Manager, assumed solution wouldn't be in there.

Thanks a million again!

MGN’s picture

MGN commented

Great. The patch has been modified somewhat to better address #395082: Confilct with Taxonomy Manager. Call to undefined function taxonomy_term_page(), but it still uses the same hook_menu_alter approach (instead of hook_menu) to override the core taxonomy pages. Once that issue has cleared, I'll commit the fix and release 6.x-1.1 shortly thereafter. Thanks again for testing.

MGN’s picture

MGN commented
Status: Postponed (maintainer needs more info) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.