I think, that the parameter 'operation' in function 'userpoints_nodeapi' must be more informational. For example, if user add new comment, 'operation' must be like 'insert comment', not like now 'insert'. It's was be useful for translate into various languages.
Please review patch.

CommentFileSizeAuthor
#1 userpoints_nc.module.patch1.7 KBdicreat
userpoints_nc.module.patch1.69 KBdicreat

Comments

dicreat’s picture

dicreat commented
StatusFileSize
new userpoints_nc.module.patch1.7 KB

Please review new patch, I'm forgot about translation.

shenzhuxi’s picture

shenzhuxi commented

Confirmed the patch work perfectly.

quotesbro’s picture

quotesbro commented
Category: bug » feature
Status: Needs review » Closed (works as designed)

It's useless, because entity type (node, comment, etc.) is stored in {userpoints_txn} table as well as operation.
And you shouldn't use t() because this string is stored in the database.